Changes to PartonShowerBsHepMCFilter and LHEGenericFilter #11190

perrozzi · 2015-09-08T19:02:07Z

No description provided.

bendavid · 2015-09-08T19:03:49Z

+1

cmsbuild · 2015-09-08T19:06:10Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

cmsbuild · 2015-09-08T19:06:12Z

A new Pull Request was created by @perrozzi for CMSSW_7_6_X.

port PR 11149 to 76X

It involves the following packages:

GeneratorInterface/Core
GeneratorInterface/GenFilters

@cmsbuild can you please review it and eventually sign? Thanks.
@mkirsano this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

davidlange6 · 2015-09-10T08:28:46Z

@perrozzi - please change the title of this PR to briefly describe the proposed changes for the release notes.

perrozzi · 2015-09-10T08:39:49Z

sorry, it is done now. let me know if you want me to add more details

davidlange6 · 2015-09-10T08:41:13Z

perfect, thanks!

On Sep 10, 2015, at 10:39 AM, perrozzi notifications@github.com wrote:

sorry, it is done now. let me know if you want me to add more details

—
Reply to this email directly or view it on GitHub.

davidlange6 · 2015-09-10T08:56:41Z

@cmsbuild please test

cmsbuild · 2015-09-10T09:01:20Z

The tests are being triggered in jenkins.

cmsbuild · 2015-09-10T09:06:21Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

cmsbuild · 2015-09-10T10:50:44Z

+1
Tested at: 96d00fa
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11190/7991/summary.html

cmsbuild · 2015-09-10T10:51:26Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

cmsbuild · 2015-09-10T11:46:44Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11190/7991/summary.html

cmsbuild · 2015-09-10T11:51:15Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-09-11T07:01:37Z

GeneratorInterface/GenFilters/interface/LHEGenericFilter.h

@@ -49,8 +49,10 @@ class LHEGenericFilter : public edm::EDFilter {

  edm::EDGetTokenT<LHEEventProduct> src_;
  int numRequired_;                // number of particles required to pass filter
-  bool acceptMore_;                // if true (default), accept numRequired or more.
-                                   // if false, accept events with exactly equal to numRequired.
+  std::string acceptLogic_;        // LT  meaning <


could you store this as an enum both to ensure that its always valid and to make the string comparison only once rather than many times?
@perrozzi

hi, I am not sure I understand what/how to do it.
to reduce the number of string comparisons to 1 is easy, but what do you mean with "always valid"?

did you mean something like this
perrozzi@a4863f0

perrozzi · 2015-09-15T07:13:41Z

hi, may I kindly ask you to check please? these PR is becoming a bit urgent, as it needs also to be backported to 71X to produce some MC samples. thanks a lot

cmsbuild · 2015-09-15T07:16:09Z

Pull request #11190 was updated. @vciulli, @covarell, @thuer, @cmsbuild, @bendavid, @govoni can you please check and sign again.

covarell · 2015-09-15T12:37:30Z

+1

bendavid · 2015-09-15T12:37:36Z

In the current code, whichlogic would be uninitialized if an invalid string was given.
Better to add an else LogError at the end to catch an invalid string.

cmsbuild · 2015-09-15T12:41:25Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

perrozzi · 2015-09-15T13:14:21Z

ok thanks, please check again

bendavid · 2015-09-15T13:15:35Z

+1

cmsbuild · 2015-09-15T13:16:31Z

Pull request #11190 was updated. @cmsbuild can you please check and sign again.

bendavid · 2015-09-15T13:20:34Z

+1

Changes to PartonShowerBsHepMCFilter and LHEGenericFilter

port PR 11149 second attempt

96d00fa

perrozzi mentioned this pull request Sep 8, 2015

Changes to PartonShowerBsHepMCFilter and LHEGenericFilter #11149

Merged

cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 8, 2015

cmsbuild added generators-approved fully-signed tests-pending orp-pending comparison-pending labels Sep 8, 2015

perrozzi changed the title ~~port PR 11149 to 76X~~ Changes to PartonShowerBsHepMCFilter and LHEGenericFilter Sep 10, 2015

cmsbuild added tests-started and removed tests-pending labels Sep 10, 2015

cmsbuild added tests-approved and removed tests-started labels Sep 10, 2015

cmsbuild added comparison-available and removed comparison-pending labels Sep 10, 2015

davidlange6 reviewed Sep 11, 2015
View reviewed changes

add enum

a4863f0

cmsbuild added generators-pending pending-signatures tests-pending comparison-pending and removed comparison-available fully-signed generators-approved tests-approved labels Sep 15, 2015

cmsbuild added generators-approved fully-signed and removed generators-pending pending-signatures labels Sep 15, 2015

add edm::LogError

32c66f9

davidlange6 added a commit that referenced this pull request Sep 21, 2015

Merge pull request #11190 from perrozzi/CMSSW_7_6_X

c9e8b10

Changes to PartonShowerBsHepMCFilter and LHEGenericFilter

davidlange6 merged commit c9e8b10 into cms-sw:CMSSW_7_6_X Sep 21, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes to PartonShowerBsHepMCFilter and LHEGenericFilter #11190

Changes to PartonShowerBsHepMCFilter and LHEGenericFilter #11190

perrozzi commented Sep 8, 2015

bendavid commented Sep 8, 2015

cmsbuild commented Sep 8, 2015

cmsbuild commented Sep 8, 2015

davidlange6 commented Sep 10, 2015

perrozzi commented Sep 10, 2015

davidlange6 commented Sep 10, 2015

davidlange6 commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

davidlange6 Sep 11, 2015

perrozzi Sep 11, 2015

perrozzi Sep 13, 2015

perrozzi commented Sep 15, 2015

cmsbuild commented Sep 15, 2015

covarell commented Sep 15, 2015

bendavid commented Sep 15, 2015

cmsbuild commented Sep 15, 2015

perrozzi commented Sep 15, 2015

bendavid commented Sep 15, 2015

cmsbuild commented Sep 15, 2015

bendavid commented Sep 15, 2015

Changes to PartonShowerBsHepMCFilter and LHEGenericFilter #11190

Changes to PartonShowerBsHepMCFilter and LHEGenericFilter #11190

Conversation

perrozzi commented Sep 8, 2015

bendavid commented Sep 8, 2015

cmsbuild commented Sep 8, 2015

cmsbuild commented Sep 8, 2015

davidlange6 commented Sep 10, 2015

perrozzi commented Sep 10, 2015

davidlange6 commented Sep 10, 2015

davidlange6 commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

cmsbuild commented Sep 10, 2015

davidlange6 Sep 11, 2015

Choose a reason for hiding this comment

perrozzi Sep 11, 2015

Choose a reason for hiding this comment

perrozzi Sep 13, 2015

Choose a reason for hiding this comment

perrozzi commented Sep 15, 2015

cmsbuild commented Sep 15, 2015

covarell commented Sep 15, 2015

bendavid commented Sep 15, 2015

cmsbuild commented Sep 15, 2015

perrozzi commented Sep 15, 2015

bendavid commented Sep 15, 2015

cmsbuild commented Sep 15, 2015

bendavid commented Sep 15, 2015