Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marked DataProxy as thread safe #11192

Merged
merged 1 commit into from Sep 9, 2015

Conversation

Dr15Jones
Copy link
Contributor

The static analyzer was picking up DataProxy as being thread-safe. Applied the appropriate annotation to tell the analyzer the mutable was safe because it is protected by a mutex shared by all EventSetup components.

The static analyzer was picking up DataProxy as being thread-safe. Applied the appropriate annotation to tell the analyzer the mutable was safe because it is protected by a mutex shared by all EventSetup components.
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2015

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Marked DataProxy as thread safe

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs or unless it breaks tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Sep 9, 2015
@davidlange6 davidlange6 merged commit 796bacc into cms-sw:CMSSW_7_6_X Sep 9, 2015
@Dr15Jones Dr15Jones deleted the markDataProxyThreadSafe branch September 24, 2015 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants