Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeavyIon: Add E/p cut to electrons and extend event content for electron collections. (75X backport of #11223) #11224

Merged
merged 2 commits into from Sep 22, 2015

Conversation

harmonicoscillator
Copy link
Contributor

This is a backport of #11223 to CMSSW_7_5_X.

R. Alex Barbieri added 2 commits September 10, 2015 09:50
(cherry picked from commit 615131a)
(cherry picked from commit b702018)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_5_X.

HeavyIon: Add E/p cut to electrons and extend event content for electron collections. (75X backport of #11223)

It involves the following packages:

RecoHI/Configuration
RecoHI/HiEgammaAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @echapon, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 10, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11224 a79ad08

For Heavy Ions, adding E/p cut to electrons. #11223 is the 76X version of this PR, and it has already been approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-09-09-2300 show no significant differences. A test for #11223 with workflow 140.53_RunHI2011 showed no significant differences, timing changes, or product size changes.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs once checked with relvals in the development release cycle of CMSSW (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@slava77
Copy link
Contributor

slava77 commented Sep 18, 2015

@davidlange6
was there a reason to not include this in 753?

@mandrenguyen
Copy link
Contributor

@slava77 @davidlange6
This was the last requested addition to the HI reco.
It's a shame this wasn't included in 753. What's the timescale for the next 75X release?

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 22, 2015
 HeavyIon: Add E/p cut to electrons and extend event content for electron collections. (75X backport of #11223)
@cmsbuild cmsbuild merged commit 0f6658e into cms-sw:CMSSW_7_5_X Sep 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants