Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HeavyIon: Add E/p cut to electrons and extend event content for electron collections. #11223

Merged
merged 2 commits into from Sep 13, 2015

Conversation

harmonicoscillator
Copy link
Contributor

This PR adds an E/p cut of <2 to the Heavy Ion electron reconstructions chain. The reason for this cut is to remove fake jets which arise from low-pt (very-curved) tracks attached to high pt ecal clusters. Theses "electrons" are then included in jets, but since the track is very curved the ecal cluster is not actually inside the jet.
Please see motivation slides here:
https://twiki.cern.ch/twiki/pub/CMS/PhotonAnalyses2015/20150825_fakerate.pdf
Additional documentation can be provided on request.

Additionally, this PR includes two additions to the Heavy Ion Event Content for electron-related quantities.

This PR should not affect pp workflows in any way.
Matrices 5.1 and 140.53 worked locally for me.

This will also be backported to 7_5_X.

This PR supersedes @doanhien PRs #11193 and #11191, both of those should be closed.

@harmonicoscillator
Copy link
Contributor Author

75X backport PR is #11224

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @richard-cms (R. Alex Barbieri) for CMSSW_7_6_X.

HeavyIon: Add E/p cut to electrons and extend event content for electron collections.

It involves the following packages:

RecoHI/Configuration
RecoHI/HiEgammaAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@MiheeJo, @jazzitup, @echapon, @yenjie, @kurtejung, @istaslis, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 10, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11223 b702018

For Heavy Ions, adding E/p cut to electrons.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-09-2300 show no significant differences. An extended test with 70 events of workflow 140.53_RunHI2011 against baseline CMSSW_7_6_0_pre4 also shows no significant differences. CPU timing and product sizes also did not change significantly.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 13, 2015
HeavyIon: Add E/p cut to electrons and extend event content for electron collections.
@cmsbuild cmsbuild merged commit 0e8bf36 into cms-sw:CMSSW_7_6_X Sep 13, 2015
cmsbuild added a commit that referenced this pull request Sep 22, 2015
 HeavyIon: Add E/p cut to electrons and extend event content for electron collections. (75X backport of #11223)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants