VID fix & core unit tests + Regression ValueMap Producer code cleanup. (76X)

[lgray]

Addresses some recent issues (and fixes one) for maintaining out-of-the-box functionality for VID.
Particularly that VID doesn't run on top of MiniAOD right now, after this PR it does.

There are now unit tests that ensure Electron/Photon VID runs on MiniAOD and AOD out of the box.
This will help ensure problems like the one above are not encountered again.

Fixes a small bug in the calculation of regression input values.

Vectors started with size at least three, then push_back was used to assign instead of the index.

Small changes expected to MiniAOD electron energy.

[cmsbuild]

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X.

VID fix & core unit tests + Regression ValueMap Producer code cleanup.

It involves the following packages:

RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lgray]

@ikrav I am working on the 74X backport now. You may use that for user recipes once it is available.

[lgray]

@cmsbuild please test

[lgray]

@matteosan1 Edits to regression valuemap producer.

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 209865c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11229/8025/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11229/8025/summary.html

[cmsbuild]

Pull request #11229 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 8b65eb7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11229/8068/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11229/8068/summary.html

[slava77]

note for posterity: this is the part of #11236, which actually changes the saved values; the rest is just refactoring

[slava77]

+1

for #11229 8b65eb7

• changes in the code are OK, mostly refactoring and addition of unit tests. there is also a bugfix in the regresion input variable computations
• plot from wflow 4.53 in jenkins shows the expected small change in the miniAOD electron kinematics
  
• additionally, tested locally in CMSSW_7_6_0_pre5 /test area sign590/ to check on run2 (run 251721) with more stats and check technical performance
  • plot from run 251721 DoubleEG 200 events shows about the same with a bit more statistics
    
  • timing and event sizes are essentially unchanged
• use of isnan should be replaced with something else, as reported by the static analyzer, e.g.
  https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11229/8068/llvm-analysis/report-9c70ee.html#EndPath
  Due to broken IB at this point, I suggest to make a fix in a separate technical PR.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1