Fix bug in drawing DT simhits + improvements

[namapane]

The detid returned by the simhit is the wire ID, but the position is in the ref fame of the DTLayer. This was not taken into account so the simhits were drawn in random places. An example before the fix (green=simhits, blue=reconstructed segments):

After the fix the simhits are correctly aligned:

Also:
-Fix DT simhits in RhoZ view, so that they are displayed aligned to 1D rechits.
-Draw rechits associated to segments also in the 3D view.

[cmsbuild]

A new Pull Request was created by @namapane (Nicola Amapane) for CMSSW_7_0_X.

Fix bug in drawing DT simhits + improvements

It involves the following packages:

Fireworks/Muons
Fireworks/SimData

@smuzaffar, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@alja this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

[nclopezo]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/972/summary.html

[alja]

@namapane should I put this change in 6_X and 5_X releases too?

[namapane]

For me it's fine to put it in 5X and 6X as well; if you do so, just keep
in mind that this is on top of pull req #1092.

Cheers
Nicola

On 30-Oct-13 18:16, Alja Mrak-Tadel wrote:

@namapane https://github.com/namapane should I put this change in 6_X
and 5_X releases too?

—
Reply to this email directly or view it on GitHub
#1128 (comment).