CorrectedJetProducer: change into a global::EDProducer (75x) #11300
Conversation
change all specialisations of `CorrectedJetProducer` into `global::EDProducer` modules: - `CorrectedCaloJetProducer` - `CorrectedPFJetProducer` - `CorrectedJPTJetProducer` - `CorrectedTrackJetProducer` - `CorrectedGenJetProducer`
|
please test |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_5_X. change CorrectedJetProducer into global::EDProducer It involves the following packages: JetMETCorrections/Modules @cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks. |
|
this was a rather simple change, so I suspect that there is some underlying issue ? |
|
jet correctors had thread safety issues up until this summer or so. on the other hand, somewhat centralized migration was done mainly based on a reco application and these modules are not in reco |
fwyzard
changed the title
|
tracked at #10965 |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
| { | ||
| // cache - note that variable length arrays are a GCC extension | ||
| reco::JetCorrector const * correctors[mCorrectorTokens.size()]; |
There was a problem hiding this comment.
Please don't use this construct since it is not in the C++ standard. Using a std::vector<> here is not going to even show up on the performance I bet.
There was a problem hiding this comment.
I'm not against avoiding the extensions, but if we do want to enforce it, can we add -Werror=vla to compiler options to prevent it ?
There was a problem hiding this comment.
By the way, I wouldn't mind using a boost::small_vector<> .
Can we has boost 1.58 ?
|
This code does seem to be thread-safe to me. My only comment was the use of the VLA which is not C++ compliant. |
|
please test |
|
The tests are being triggered in jenkins. |
|
@fwyzard Changing the line of code lost your comment about upgrading to boost 1.58 . @davidlange6 Is our ability to move to a new boost constrained because of the DB code's forward compatibility requirement on boost serialization? |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
|
@Dr15Jones - yes, i understood that boost 1.58 indeed is sufficient to break the db compatibility. |
|
+1 |
CorrectedJetProducer: change into a global::EDProducer (75x)
change all specialisations of
CorrectedJetProducerintoglobal::EDProducermodules:CorrectedCaloJetProducerCorrectedPFJetProducerCorrectedJPTJetProducerCorrectedTrackJetProducerCorrectedGenJetProducer