Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove penalty on unganged ME11A #11305

Merged
merged 4 commits into from Sep 24, 2015

Conversation

jhgoh
Copy link
Contributor

@jhgoh jhgoh commented Sep 17, 2015

A penalty have been applied in the muon seeding for the segments from ME11A to account ganged CSCs.
With this PR, penalty is not applied for un-ganged ones in ME11A.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_7_6_X.

Remove penalty from ganged CSC

It involves the following packages:

RecoMuon/MuonSeedGenerator

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @bellan, @trocino, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 17, 2015

@cmsbuild please test

@slava77
Copy link
Contributor

slava77 commented Sep 17, 2015

@jhgoh
John, the PR description doesn't quite match the code change: what is done is to apply penalty only to ganged ME11A (run1) and not apply it for unganged one (run2 and later).
So, "remove penalty on unganged ME11A" or similar is a more appropriate subject (you can edit it by clicking "Edit" button on the upper right of your PR).

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@jhgoh jhgoh changed the title Remove penalty from ganged CSC Remove penalty on unganged ME11A Sep 17, 2015
@jhgoh
Copy link
Contributor Author

jhgoh commented Sep 17, 2015

@slava77 thank you. title is changed :-)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11305 613298d

From Run 1 to Run 2, CSC ME11A chambers have become unganged. ME11A chambers were given a muon seeding penalty in Run 1. This change applies the penalty only to ganged chambers (Run 1), not the refurbished ME11A chambers for Run 2.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_6_X_2015-09-16-2300 show no significant differences, as expected. An extended test of workflow 25206.0_ZMM_13 with 100 events against baseline CMSSW_7_6_X_2015-09-16-2300 also shows no significant differences. There are a few small changes, like the following example.
eff
Note the "Run1" label on the plot does not refer to conditions. This plot is based upon run2_mc conditions with ME11A unganged.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 24, 2015
@cmsbuild cmsbuild merged commit 11f4b54 into cms-sw:CMSSW_7_6_X Sep 24, 2015
@jhgoh jhgoh deleted the RemovePenaltyGangedCSC branch September 24, 2015 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants