Resolve issues with streams (getline(), stream to void *, etc) #11309
Conversation
GCC 5.2.0 does not allow piping output stream into output stream, e.g., `std::cout << std::cout`. There is no more impilicit conversion to `void *` since C++11. `std::getline()` returns `std::basic_istream` and implicit conversion to `void *` does not happen. Since C++11 you can use any function returning references to streams as loop conditions. This is because `explicit operator bool() const` was introduced since C++11. To validate stream status you need to use `operator!`, `fail()`, `eof()`, `bad()` and friends from `std::basic_ios`. Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_6_X. Resolve issues with streams (getline(), stream to void *, etc) It involves the following packages: Alignment/CommonAlignmentProducer @diguida, @cerminar, @cmsbuild, @ggovi, @mmusich, @mulhearn can you please review it and eventually sign? Thanks. |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 |
Resolve issues with streams (getline(), stream to void *, etc)
GCC 5.2.0 does not allow piping output stream into output stream, e.g.,
std::cout << std::cout. There is no more impilicit conversion tovoid *since C++11.std::getline()returnsstd::basic_istreamand implicit conversion tovoid *does not happen. Since C++11 you can use any function returningreferences to streams as loop conditions. This is because
explicit operator bool() constwas introduced since C++11.To validate stream status you need to use
operator!,fail(),eof(),bad()and friends fromstd::basic_ios.Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch