Missing virtual destructor #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_0_X. Missing virtual destructor It involves the following packages: CondFormats/L1TObjects @smuzaffar, @apfeiffer1, @nclopezo, @demattia, @rcastello, @ggovi, @mulhearn can you please review it and eventually sign? Thanks. |
|
+1 |
|
bypassing and merging. Please shout if wrong. |
ktf
added a commit
that referenced
this pull request
Oct 22, 2013
ROOT 6 -- Missing virtual destructor in CondFormats/L1TObjects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The class L1MuPacking is an abstract base class with all functions virtual. However, it does not have a virtual destructor, as it should. This will likely not cause splitting, because the class has no data members. However, it does prevent the ROOT6 dictionary from compiling.
This pull request adds the missing virtual destructor.