correctedP4 must return a copy of p4() #11311
Conversation
`correctedJet()` returns a new `Jet` object. In `correctedP4()` we
return a reference to p4() on a stack, thus the reference is invalid and
most likely value will be changed with the next few function calls.
DataFormats/PatCandidates/interface/Jet.h:155:178: error: function
returns address of local variable [-Werror=return-local-addr]
DataFormats/PatCandidates/interface/Jet.h:158:204: error: function
returns address of local variable [-Werror=return-local-addr]
A quick fix (this patch) is to make `correctedP4()` return a copy
instead of a reference.
If `correctedJet()` is on hot path, the new `Jet` object should be
cached and then we could also return a reference in `correctedP4()`.
Signed-off-by: David Abdurachmanov <David.Abdurachmanov@cern.ch>
|
A new Pull Request was created by @davidlt for CMSSW_7_6_X. correctedP4 must return a copy of p4() It involves the following packages: DataFormats/PatCandidates @cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks. |
|
looks right to me in fact, if correctedJet() starts to matter in terms of time, correctedP4() should be implemented in a better way calling the method that computes the correction factor and not the full corrected jet. Giovanni |
|
ping^1 |
|
+1 |
cmsbuild
added
analysis-approved
fully-signed
and removed
analysis-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
|
+1 |
correctedP4 must return a copy of p4()
correctedJet()returns a newJetobject. IncorrectedP4()wereturn a reference to p4() on a stack, thus the reference is invalid and
most likely value will be changed with the next few function calls.
A quick fix (this patch) is to make
correctedP4()return a copyinstead of a reference.
If
correctedJet()is on hot path, the newJetobject should becached and then we could also return a reference in
correctedP4().Signed-off-by: David Abdurachmanov David.Abdurachmanov@cern.ch