Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clang static analyzer warning using namespace in header #11324

Merged
merged 2 commits into from Sep 19, 2015
Merged

fix clang static analyzer warning using namespace in header #11324

merged 2 commits into from Sep 19, 2015

Conversation

gartung
Copy link
Member

@gartung gartung commented Sep 17, 2015

No description provided.

@gartung
Copy link
Member Author

gartung commented Sep 17, 2015

@mulhearn

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_6_X.

fix clang static analyzer warning using namespace in header

It involves the following packages:

CalibCalorimetry/HcalTPGAlgos

@cmsbuild, @mmusich, @diguida, @mulhearn, @cerminar can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Sep 17, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-1
Tested at: 5222be1
I found an error when building:

>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalChannelDataXml.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalChannelIterator.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalChannelQualityXml.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/HcalDbOmds.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/DBlmapWriter.cc: In member function 'XMLDOMBlock\* DBlmapWriter::createLMapHBEFXMLBase(std::string)':
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/DBlmapWriter.cc:19:3: error: 'DOMDocument' was not declared in this scope
   DOMDocument \* loader = result -> getDocument();
   ^
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-09-16-2300/src/CaloOnlineTools/HcalOnlineDb/src/DBlmapWriter.cc:19:3: note: suggested alternative:
In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/external/xerces-c/2.8.0/include/xercesc/parsers/AbstractDOMParser.hpp:25:0,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc6_amd64_gcc493/external/xerces-c/2.8.0/include/xercesc/parsers/XercesDOMParser.hpp:27,


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11324/8170/summary.html

@gartung
Copy link
Member Author

gartung commented Sep 17, 2015

@mmusich Updated dependent package CaloOnlineTool/HcalOnlineDb.

@mmusich
Copy link
Contributor

mmusich commented Sep 17, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

Pull request #11324 was updated. @diguida, @cerminar, @cmsbuild, @ggovi, @mmusich, @mulhearn can you please check and sign again.

@cmsbuild
Copy link
Contributor

davidlange6 added a commit that referenced this pull request Sep 19, 2015
…fix-clang-warning-2

fix clang static analyzer warning using namespace in header
@davidlange6 davidlange6 merged commit fe96bd7 into cms-sw:CMSSW_7_6_X Sep 19, 2015
@gartung gartung deleted the CalibCalorimetry-HcalTPGAlgos-fix-clang-warning-2 branch September 21, 2015 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants