Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Higgs Dalitz paths (74X) #11344

Merged

Conversation

jasperlauwers
Copy link
Contributor

backport of #11340

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jasperlauwers for CMSSW_7_4_X.

Update Higgs Dalitz paths (74X)

It involves the following packages:

HLTriggerOffline/Higgs

@cmsbuild, @danduggan, @broen, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@perrotta
Copy link
Contributor

@jasperlauwers : only the last commit in this ticket is actually the backport of #11340.
Could you please make separate pull requests for separate updates/fixes?
As such you would speed up the merging of the part which relates to the additional monitoring of the new Dalitz path(s), and as a consequence the integration of the new paths in the HLT menu.

@deguio
Copy link
Contributor

deguio commented Sep 23, 2015

please test

@deguio
Copy link
Contributor

deguio commented Sep 23, 2015

@davidlange6 should comment about policies, but decoupling the two set of changes should speed up the integration.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@jasperlauwers
Copy link
Contributor Author

All commits before the last one are in #11209
I'm a bit lost in what exactly you want me to do. Also because #11209 contains a new path (HLT_Ele23_WPLoose_Gsf_WHbbBoost_v1) that didn't need to be fully merged in 75x and 74x to get the green light from STEAM.
Could you please clearify if you want me to rebase #11209 on top of the new commit in this PR so this commit can be merged faster?

@perrotta
Copy link
Contributor

@jasperlauwers : we already decided to include the new paths even if these 74X/75X PR's could not be fully signed yet, because the DQM update requested (included in your last commit) is trivial, and already merged in 76X. Therefore, do whatever you prefer with these backport PR's (provided you keep taking care of them whenever needed).

Anyhow, I think that n principle you should have rather had to backport one PR at a time instead of mixing all them together, especially if the easy one is requested for the integration of the new paths in the HLT menu, and it can be stopped by the toughest part of the cumulative PR.

(Please, contact me privately if you want to continue this discussion. Or join us tomorrow at the TSG meeting)

@deguio
Copy link
Contributor

deguio commented Sep 24, 2015

+1
I would have created a PR containing only the last commit so that the cfg path update can be merged faster, but fine. approving this one.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

Pull request #11344 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Oct 10, 2015

please test

@deguio
Copy link
Contributor

deguio commented Oct 10, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8749/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@jasperlauwers
Copy link
Contributor Author

The commits in this PR have been validated in 7_6_0_pre6. Can it be merged?

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 20, 2015
…alitz_74

Update Higgs Dalitz paths (74X)
@cmsbuild cmsbuild merged commit 8558d04 into cms-sw:CMSSW_7_4_X Oct 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants