Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniAOD fixes from e/gamma merged together for 7412patch2 #11345

Merged
merged 12 commits into from Sep 18, 2015

Conversation

davidlange6
Copy link
Contributor

#11232, #11262, #11282 combined and put on branch for 7_4_12_patch2

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_4_12_patchX.

miniAOD fixes from e/gamma merged together for 7412patch2

It involves the following packages:

RecoEgamma/EgammaTools
RecoEgamma/ElectronIdentification
RecoEgamma/PhotonIdentification

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.

Note that this branch is designed for requested bug fixes specific to the CMSSW_7_4_12 release.
If you wish to make a pull request for the CMSSW_7_4_X release cycle, please use the CMSSW_7_4_X branch instead

@slava77
Copy link
Contributor

slava77 commented Sep 18, 2015

@cmsbuild please test
just to have a combined checkpoint

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@davidlange6
Copy link
Contributor Author

We don't have an ib to test with

On Sep 18, 2015, at 2:51 PM, Slava Krutelyov <notifications@github.commailto:notifications@github.com> wrote:

@cmsbuildhttps://github.com/cmsbuild please test
just to have a combined checkpoint


Reply to this email directly or view it on GitHubhttps://github.com//pull/11345#issuecomment-141443418.

@slava77
Copy link
Contributor

slava77 commented Sep 18, 2015

ah, I missed that it's branching off

@cmsbuild cmsbuild added this to the Next CMSSW_7_4_12_patchX milestone Sep 18, 2015
@smuzaffar
Copy link
Contributor

as requested by @davidlange6 , I am merging it and starting CMSSW_7_4_12_patch2

smuzaffar added a commit that referenced this pull request Sep 18, 2015
miniAOD fixes from e/gamma merged together for 7412patch2
@smuzaffar smuzaffar merged commit bc84795 into cms-sw:CMSSW_7_4_12_patchX Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants