Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4-lines constexpr omission fix (75X) #11376

Merged
merged 1 commit into from Sep 20, 2015

Conversation

abdoulline
Copy link

complementary to PR#11101

@abdoulline abdoulline changed the title 4-lines constexpr omission fix, complementary to PR#11101 4-lines constexpr omission fix Sep 18, 2015
@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Sep 18, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abdoulline (Salavat Abdullin) for CMSSW_7_5_X.

4-lines constexpr omission fix

It involves the following packages:

RecoLocalCalo/HcalRecAlgos

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented Sep 18, 2015

@abdoulline please make one for 76X as well
(ideally, the same abdoulline:HcalRecAlgos_fix75X should work, but with recent changes in HCAL code, I wouldn't be so sure. If it doesn't, then a separate branch with respect to 76X will be needed)
Thank you.

@slava77
Copy link
Contributor

slava77 commented Sep 18, 2015

ok, I noticed #11377

@abdoulline abdoulline changed the title 4-lines constexpr omission fix 4-lines constexpr omission fix (75X) Sep 18, 2015
@slava77
Copy link
Contributor

slava77 commented Sep 18, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 18, 2015

+1

for #11376 10b1d1b

  • symbols added to .cc file as expected
  • jenkins tests pass (compilation was enough), comparisons with baseline show no differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 20, 2015
4-lines constexpr omission fix (75X)
@cmsbuild cmsbuild merged commit abec2c5 into cms-sw:CMSSW_7_5_X Sep 20, 2015
@abdoulline abdoulline deleted the HcalRecAlgos_fix75X branch April 13, 2017 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants