Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add combMVAV2 to DQM common configuration #11380

Merged
merged 1 commit into from Sep 23, 2015

Conversation

pablodecm
Copy link
Contributor

This PR adds combMVAV2 to the DQMOffline. Because the bTagGenericAnalysisBlock config
is used only a python configuration has to be modified.

I run several tests (FullSim, Data and FastSim) with the runTheMatrix.py script and everything
seem to work as expected.

This changes have to be backported to 75X and 74X as soon as possible.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pablodecm (Pablo de Castro) for CMSSW_7_6_X.

Add combMVAV2 to DQM common configuration

It involves the following packages:

DQMOffline/RecoB

@cmsbuild, @danduggan, @broen, @deguio can you please review it and eventually sign? Thanks.
@ferencek, @acaudron, @rociovilar, @pvmulder, @imarches this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 21, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Sep 23, 2015

+1
consider backporting to 75 and 74

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 23, 2015
Add combMVAV2 to DQM common configuration
@cmsbuild cmsbuild merged commit d089c06 into cms-sw:CMSSW_7_6_X Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants