Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New GTs for 75X: Hcal MC response corrections and other fixes #11390

Closed
wants to merge 2 commits into from

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 21, 2015

Summary of changes

Run1 simulation

Run1 data

  • Offline: 75X_dataRun1_v5: As 75X_dataRun1_v4 with the following changes:
    • adding BTag conditions as GRBForest payloads;
    • adding HF tower description for HeavyIons as new label in HevayIonRcd;
    • updating HCAL channel quality: mark 18 HCAL channels of a particular HPD as bad (0x8002) in the run range 253937 - 255294 due to a mistakenly set low bias voltage.
    • taxonomy change for Muon APE tags
  • HLT: 75X_dataRun1_HLT_frozen_v3: As 75X_dataRun1_HLT_frozen_v2 with the following changes:
    • taxonomy change for Muon APE tags;
    • taxonomy change for SiStrip back-plane corrections in deconvolution mode;
    • new snapshot time: 2015-09-21 07:47:14.

Run2 simulation

  • Ideal: 75X_mcRun2_design_v5: As 75X_mcRun2_design_v4 with the following changes:
    • adding BTag conditions as GRBForest payloads;
    • new 25ns JEC including PUPPI;
    • Hcal response corrections from Data/MC comparison;
    • Hcal ZS thresholds to simulate HF zero suppresion settings;
    • New 25ns JECs for HLT;
    • New L1 menu for stage1 (v5).
  • Startup: 75X_mcRun2_startup_v5: As 75X_mcRun2_startup_v2 with the following changes:
    • adding BTag conditions as GRBForest payloads;
    • new Pixel dead channel map (from Run2015C);
    • new 50ns JEC including PUPPI;
    • Hcal response corrections from Data/MC comparison;
    • Hcal ZS thresholds to simulate HF zero suppresion settings.
  • Asymptotic: 75X_mcRun2_asymptotic_v6: As 75X_mcRun2_asymptotic_v5 with the following changes:
    • adding BTag conditions as GRBForest payloads;
    • new Pixel dead channel map (from Run2015C);
    • new 50ns JEC including PUPPI;
    • Hcal response corrections from Data/MC comparison;
    • Hcal ZS thresholds to simulate HF zero suppresion settings;
    • New 25ns JECs for HLT;
    • New L1 menu for stage1 (v5).
  • Heavy Ion: 75X_mcRun2_HeavyIon_v4: As 75X_mcRun2_HeavyIon_v4 with the following changes:
    • adding BTag conditions as GRBForest payloads;
    • new Pixel dead channel map (from Run2015C);
    • new 25ns JEC including PUPPI;
    • Hcal response corrections from Data/MC comparison;
    • Hcal ZS thresholds to simulate HF zero suppresion settings;
    • New 25ns JECs for HLT;
    • New L1 menu for stage1 (v5);
    • Adding new Centrality table in HeavyIonRcd with label HFtowersHydjetDrum5.

Run2 data

  • Offline: 75X_dataRun2_v6: As 75X_dataRun2_v5 with the following changes:
    • adding BTag conditions as GRBForest payloads;
    • adding new Centrality Table for HF tower description for HeavyIons as new label in HevayIonRcd;
    • updating HCAL channel quality: mark 18 HCAL channels of a particular HPD as bad (0x8002) in the run range 253937 - 255294 due to a mistakenly set low bias voltage;
    • updating JEC for data (25ns-50ns transitions are handled via IOV) including new labels for PUPPI;
    • taxonomy change for Muon APE tags.
  • HLT: 75X_dataRun2_HLT_frozen_v3: As 75X_dataRun2_HLT_frozen_v2 with the following changes:
    • taxonomy change for Muon APE tags;
    • taxonomy change for SiStrip back plane corrections in deconvolution mode;
    • new snapshot time: 2015-09-21 07:47:14.

@diguida
Copy link
Contributor

diguida commented Sep 21, 2015

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Sep 21, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_7_5_X.

New GTs for 75X: Hcal MC tesponse corrections and other fixes

It involves the following packages:

Configuration/AlCa

@cmsbuild, @mmusich, @diguida, @cerminar can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich mmusich changed the title New GTs for 75X: Hcal MC tesponse corrections and other fixes New GTs for 75X: Hcal MC response corrections and other fixes Sep 21, 2015
@cmsbuild
Copy link
Contributor

-1
Tested at: 96d2909
When I ran the RelVals I found an error in the following worklfows:
135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log
----- Begin Fatal Exception 21-Sep-2015 11:18:20 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'HLT_DoubleMediumIsoPFTau40_Trk1_eta2p1_Reg_v2'
   [2] Calling event method for module HLTLevel1GTSeed/'hltL1sDoubleIsoTau32erORDoubleIsoTau36erORDoubleIsoTau40erORDoubleIsoTau44er'
Exception Message:
Algorithm  L1_DoubleIsoTau44er, requested as seed by a HLT path, not found in the L1 trigger menu
   L1Menu_Collisions2015_25nsStage1_v5/L1T_Scales_20141121/Imp0
Incompatible L1 and HLT menus.
----- End Fatal Exception -------------------------------------------------

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 21-Sep-2015 11:25:40 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'HLT_DoubleMediumIsoPFTau40_Trk1_eta2p1_Reg_v2'
   [2] Calling event method for module HLTLevel1GTSeed/'hltL1sDoubleIsoTau32erORDoubleIsoTau36erORDoubleIsoTau40erORDoubleIsoTau44er'
Exception Message:
Algorithm  L1_DoubleIsoTau44er, requested as seed by a HLT path, not found in the L1 trigger menu
   L1Menu_Collisions2015_25nsStage1_v5/L1T_Scales_20141121/Imp0
Incompatible L1 and HLT menus.
----- End Fatal Exception -------------------------------------------------

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 21-Sep-2015 11:29:40 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'HLT_DoubleMediumIsoPFTau40_Trk1_eta2p1_Reg_v2'
   [2] Calling event method for module HLTLevel1GTSeed/'hltL1sDoubleIsoTau32erORDoubleIsoTau36erORDoubleIsoTau40erORDoubleIsoTau44er'
Exception Message:
Algorithm  L1_DoubleIsoTau44er, requested as seed by a HLT path, not found in the L1 trigger menu
   L1Menu_Collisions2015_25nsStage1_v5/L1T_Scales_20141121/Imp0
Incompatible L1 and HLT menus.
----- End Fatal Exception -------------------------------------------------

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 21-Sep-2015 11:37:17 CEST-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'HLT_DoubleMediumIsoPFTau40_Trk1_eta2p1_Reg_v2'
   [2] Calling event method for module HLTLevel1GTSeed/'hltL1sDoubleIsoTau32erORDoubleIsoTau36erORDoubleIsoTau40erORDoubleIsoTau44er'
Exception Message:
Algorithm  L1_DoubleIsoTau44er, requested as seed by a HLT path, not found in the L1 trigger menu
   L1Menu_Collisions2015_25nsStage1_v5/L1T_Scales_20141121/Imp0
Incompatible L1 and HLT menus.
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11390/8227/summary.html

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2015

@Martin-Grunewald seems to fail due to mismatch with the HLT menu (we have put the version V5 L1 Stage1 menu in the MC GTs as requested)

@Martin-Grunewald
Copy link
Contributor

@mmusich
Great, thanks! Indeed we now need to switch the relval HLT menus as well. I'll do so!
(BTW, what is the status for 76X?)

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2015

@Martin-Grunewald errr... as soon as #10353 is merged we will have a solid base to build the new version....

@Martin-Grunewald
Copy link
Contributor

@mmusich
75X: please see #11391

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2015

@Martin-Grunewald thanks!

@diguida
Copy link
Contributor

diguida commented Sep 21, 2015

@Martin-Grunewald @mmusich
IIRC I have a "minimal" set of GT in 76X including all changes but HCAL geometry... If so, you can use it for testing in a private branch. Then, when #10353 is included, you can just rebase and add the missing fixes in the menu.

@mmusich
Copy link
Contributor Author

mmusich commented Sep 21, 2015

superseded by #11391

@mmusich mmusich closed this Sep 21, 2015
@cmsbuild
Copy link
Contributor

Pull request #11390 was updated. @cmsbuild, @mmusich, @diguida, @franzoni, @cerminar can you please check and sign again.

@diguida
Copy link
Contributor

diguida commented Sep 22, 2015

-1
superseded by #11391

@mmusich
Copy link
Contributor Author

mmusich commented Sep 23, 2015

since this needs corresponding changes to the HLT menu, I am going to close it.

@mmusich mmusich closed this Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants