Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sigmaIetaIphi for photon regression (75X) #11406

Merged
merged 1 commit into from Oct 12, 2015

Conversation

lgray
Copy link
Contributor

@lgray lgray commented Sep 21, 2015

Forward port of #11403.

@lgray
Copy link
Contributor Author

lgray commented Sep 21, 2015

@cmsbuild please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_5_X milestone Sep 21, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

Fix sigmaIetaIphi for photon regression (75X)

It involves the following packages:

RecoEgamma/EgammaTools

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Sep 24, 2015

I suppose this PR goes in only if we kill the RECO-based regression PR #11402, right?

@lgray
Copy link
Contributor Author

lgray commented Sep 24, 2015

Yes.

(Sent from my Nexus 6)
On Sep 24, 2015 2:42 PM, "Slava Krutelyov" notifications@github.com wrote:

I suppose this PR goes in only if we kill the RECO-based regression PR
#11402 #11402, right?


Reply to this email directly or view it on GitHub
#11406 (comment).

@slava77
Copy link
Contributor

slava77 commented Sep 28, 2015

+1

for #11406 3b2a460

  • small fix in the definition of the regression input variable for the miniAOD photon energy correction
  • the same changes as in 74X Fix sigmaIetaIphi for photon regression (74X not patches) #11405 93f9992; see details of performance changes there
    • miniAOD photon energies are changed slightly after the fix
  • jenkins tests pass and comparisons with baseline showed no differences (the variables are not monitored in current miniAOD monitoring)

This PR is not needed if #11402 can be merged (requires a relval cycle).
If 75X DR campaign/reprocessing release should be cut before 760pre6 relval or another 75X relval cycle is in order, this PR should be merged in 75X.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 12, 2015
Fix sigmaIetaIphi for photon regression (75X)
@cmsbuild cmsbuild merged commit 9ba6d58 into cms-sw:CMSSW_7_5_X Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants