PositionCalc Fix

[argiro]

removed cache for CaloGeometry

[cmsbuild]

A new Pull Request was created by @argiro for CMSSW_7_5_X.

PositionCalc Fix

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[lgray]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: f452a48
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11417/8262/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11417/8262/summary.html

[cvuosalo]

+1

For #11417 f452a48

Fixing buggy code related to the ECAL 2D position that was causing sporadic crashes. There should be no change in monitored quantities. #11415 is the 74X version of this PR, and it has already been merged.

The code change fixes incorrect code. Jenkins tests against baseline CMSSW_7_5_X_2015-09-22-1100 show no significant differences, as expected. A test of workflow 25202.0_TTbar_13 with 70 events against baseline CMSSW_7_5_3 also shows no significant differences. Timing measurements show that the module particleFlowClusterECALUncorrected, the only user in RECO of the class ECAL2DPositionCalcWithDepthCorr that is changed by this PR, shows no significant change in timing with respect to the baseline.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1