Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Position Calc Fix 76X #11418

Merged
merged 1 commit into from Sep 23, 2015
Merged

Conversation

argiro
Copy link
Contributor

@argiro argiro commented Sep 22, 2015

removed cache for CaloGeometry

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @argiro for CMSSW_7_6_X.

Position Calc Fix 76X

It involves the following packages:

RecoParticleFlow/PFClusterProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor

lgray commented Sep 22, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cvuosalo
Copy link
Contributor

+1

For #11418 f452a48

Fixing buggy code related to the ECAL 2D position that was causing sporadic crashes. There should be no change in monitored quantities. #11415 and #11417 are the 74X and 75X versions of this PR. The first has already been merged, while the second has already been approved by Reco.

The code change fixes incorrect code. Jenkins tests against baseline CMSSW_7_6_X_2015-09-21-2300 show no significant differences, as expected. Additional testing was done for #11417 and found no significant changes in quantities or timing.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 23, 2015
@cmsbuild cmsbuild merged commit 6fcb5a2 into cms-sw:CMSSW_7_6_X Sep 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants