Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now the code is able to handle non consecutive LS #11446

Merged
merged 4 commits into from Sep 29, 2015
Merged

Now the code is able to handle non consecutive LS #11446

merged 4 commits into from Sep 29, 2015

Conversation

dinardo
Copy link
Contributor

@dinardo dinardo commented Sep 23, 2015

I contacted the experts in order to understand exactly how the LS stream is handled in the DQM and they told me that it's not guaranteed that they will be consecutive. I've therefore changed the code in order to cope with non consecutive LSs.

  • Mauro.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dinardo (Mauro) for CMSSW_7_4_X.

Now the code is able to handle non consecutive LS

It involves the following packages:

DQM/BeamMonitor
DQM/Integration

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@threus, @batinkov this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 24, 2015

this PR should contain the changes from
#11445 (pending in 76)
#11256 (merged in 76)

@dinardo please tell me if this is not the case

@deguio
Copy link
Contributor

deguio commented Sep 24, 2015

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Sep 24, 2015

+1
this is online only and would be nice to have in the next build

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Sep 29, 2015
Now the code is able to handle non consecutive LS
@cmsbuild cmsbuild merged commit d4cea91 into cms-sw:CMSSW_7_4_X Sep 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants