bsunanda:Run2-hcx31 Add simulation code for HGCal and single layer fast timing device #11498

bsunanda · 2015-09-25T21:41:08Z

Code of detectors only for Phase 2.

cmsbuild · 2015-09-25T21:46:11Z

A new Pull Request was created by @bsunanda for CMSSW_7_6_X.

bsunanda:Run2-hcx31 Add simulation code for HGCal and single layer fast timing device

It involves the following packages:

SimG4CMS/Calo
SimG4CMS/Forward
SimG4Core/Application

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

lgray · 2015-09-28T11:36:40Z

@cmsbuild please test

@sethzenz @kpedro88 @vandreev11 @pfs

cmsbuild · 2015-09-28T11:41:31Z

The tests are being triggered in jenkins.

civanch · 2015-09-28T12:57:11Z

@bsunanda , why you have integer

HGCSD = cms.PSet(
...

```
   TimeSliceUnit    = cms.int32(1),
```
....

but double time slices for old detectors?

cmsbuild · 2015-09-28T13:02:00Z

-1
Tested at: d989930
When I ran the RelVals I found an error in the following worklfows:
8.0 step1

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step1_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log
----- Begin Fatal Exception 28-Sep-2015 14:15:43 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module OscarMTProducer/'g4SimHits'
Exception Message:
ValueError type of TimeSliceUnit is expected to be int but declared as double
----- End Fatal Exception -------------------------------------------------

9.0 step1

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step1_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log
----- Begin Fatal Exception 28-Sep-2015 14:16:43 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module OscarMTProducer/'g4SimHits'
Exception Message:
ValueError type of TimeSliceUnit is expected to be int but declared as double
----- End Fatal Exception -------------------------------------------------

25.0 step1

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step1_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
----- Begin Fatal Exception 28-Sep-2015 14:17:47 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module OscarMTProducer/'g4SimHits'
Exception Message:
ValueError type of TimeSliceUnit is expected to be int but declared as double
----- End Fatal Exception -------------------------------------------------

1306.0 step1

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step1_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 28-Sep-2015 14:22:00 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module OscarMTProducer/'g4SimHits'
Exception Message:
ValueError type of TimeSliceUnit is expected to be int but declared as double
----- End Fatal Exception -------------------------------------------------

1330.0 step1

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step1_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log
----- Begin Fatal Exception 28-Sep-2015 14:23:17 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module OscarMTProducer/'g4SimHits'
Exception Message:
ValueError type of TimeSliceUnit is expected to be int but declared as double
----- End Fatal Exception -------------------------------------------------

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log
----- Begin Fatal Exception 28-Sep-2015 14:25:16 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module OscarMTProducer/'g4SimHits'
Exception Message:
ValueError type of TimeSliceUnit is expected to be int but declared as double
----- End Fatal Exception -------------------------------------------------

25202.0 step1

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step1_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 28-Sep-2015 14:26:39 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module OscarMTProducer/'g4SimHits'
Exception Message:
ValueError type of TimeSliceUnit is expected to be int but declared as double
----- End Fatal Exception -------------------------------------------------

50202.0 step1

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step1_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 28-Sep-2015 14:27:46 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Processing run: 1 lumi: 1 event: 1
   [1] Running path 'simulation_step'
   [2] Calling event method for module OscarMTProducer/'g4SimHits'
Exception Message:
ValueError type of TimeSliceUnit is expected to be int but declared as double
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11498/8429/summary.html

lgray · 2015-09-28T13:23:30Z

@bsunanda Please do runTheMatrix.py -s -i all -j 8 to check that things run before you submit pull requests. Here, though, it looks like a commit was forgotten, perhaps?

bsunanda · 2015-09-28T14:51:35Z

I did the runTheMatrix - I do not understand how it misses these. Now the corrected version is committed

From: Lindsey Gray [notifications@github.com]
Sent: 28 September 2015 15:23
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda:Run2-hcx31 Add simulation code for HGCal and single layer fast timing device (#11498)

@bsunandahttps://github.com/bsunanda Please do runTheMatrix.py -s -i all -j 8 to check that things run before you submit pull requests. Here, though, it looks like a commit was forgotten, perhaps?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/11498#issuecomment-143742811.

lgray · 2015-09-28T14:53:31Z

@cmsbuild please test

cmsbuild · 2015-09-28T14:56:59Z

The tests are being triggered in jenkins.

cmsbuild · 2015-09-28T14:57:01Z

Pull request #11498 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

cmsbuild · 2015-09-28T17:23:25Z

+1
Tested at: e7b85f6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11498/8447/summary.html

cmsbuild · 2015-09-28T18:33:27Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11498/8447/summary.html

cmsbuild · 2015-10-06T16:07:03Z

The tests are being triggered in jenkins.

cmsbuild · 2015-10-06T16:07:05Z

Pull request #11498 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

cmsbuild · 2015-10-06T18:30:45Z

+1
Tested at: 6d5990a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11498/8645/summary.html

cmsbuild · 2015-10-06T19:21:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11498/8645/summary.html

lgray · 2015-10-06T22:41:21Z

@civanch, @mdhildreth Please recheck and resign this PR as you are able. Thanks!

civanch · 2015-10-07T09:00:43Z

+1

cmsbuild · 2015-10-07T09:06:41Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-10-07T09:49:23Z

+1

bsunanda:Run2-hcx31 Add simulation code for HGCal and single layer fast timing device

cmsbuild added this to the Next CMSSW_7_6_X milestone Sep 25, 2015

cmsbuild added simulation-pending pending-signatures tests-pending orp-pending comparison-pending labels Sep 25, 2015

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2015

cmsbuild added tests-rejected and removed tests-started labels Sep 28, 2015

cmsbuild added tests-pending and removed tests-rejected labels Sep 28, 2015

cmsbuild added tests-started and removed tests-pending labels Sep 28, 2015

cmsbuild added tests-approved and removed tests-started labels Sep 28, 2015

cmsbuild added comparison-available and removed comparison-pending labels Sep 28, 2015

cmsbuild added simulation-pending pending-signatures tests-pending comparison-pending and removed comparison-available fully-signed simulation-approved tests-approved labels Oct 6, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 6, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 6, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 6, 2015

cmsbuild added simulation-approved fully-signed and removed pending-signatures simulation-pending labels Oct 7, 2015

cmsbuild added orp-approved and removed orp-pending labels Oct 7, 2015

cmsbuild added a commit that referenced this pull request Oct 7, 2015

Merge pull request #11498 from bsunanda/Run2-hcx31

7c18e3b

bsunanda:Run2-hcx31 Add simulation code for HGCal and single layer fast timing device

cmsbuild merged commit 7c18e3b into cms-sw:CMSSW_7_6_X Oct 7, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bsunanda:Run2-hcx31 Add simulation code for HGCal and single layer fast timing device #11498

bsunanda:Run2-hcx31 Add simulation code for HGCal and single layer fast timing device #11498

bsunanda commented Sep 25, 2015

cmsbuild commented Sep 25, 2015

lgray commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

civanch commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

lgray commented Sep 28, 2015

bsunanda commented Sep 28, 2015

lgray commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

lgray commented Oct 6, 2015

civanch commented Oct 7, 2015

cmsbuild commented Oct 7, 2015

davidlange6 commented Oct 7, 2015

bsunanda:Run2-hcx31 Add simulation code for HGCal and single layer fast timing device #11498

bsunanda:Run2-hcx31 Add simulation code for HGCal and single layer fast timing device #11498

Conversation

bsunanda commented Sep 25, 2015

cmsbuild commented Sep 25, 2015

lgray commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

civanch commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

lgray commented Sep 28, 2015

bsunanda commented Sep 28, 2015

lgray commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Sep 28, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

lgray commented Oct 6, 2015

civanch commented Oct 7, 2015

cmsbuild commented Oct 7, 2015

davidlange6 commented Oct 7, 2015