Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-port of a set of fixes for the conddb core #11518

Merged
merged 1 commit into from Oct 10, 2015

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Sep 28, 2015

Fixes back-ported:

  • remove of Root based serialization
  • addition of CMSSW and boost serialization version information as payload metadata
  • improved handling of exception in serialization/deserialization
  • fix for condition overriding with toGet: support of '@' characters in sqlite file names (!)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ggovi for CMSSW_7_4_X.

Back-port of a set of fixes for the conddb core

It involves the following packages:

CondCore/CondDB

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ggovi
Copy link
Contributor Author

ggovi commented Sep 28, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@ggovi
Copy link
Contributor Author

ggovi commented Sep 28, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@ggovi
Copy link
Contributor Author

ggovi commented Oct 6, 2015

@davidlange6
Hello David, this PR has been mentioned at the ORP last week. Is this ok for the approval?

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 10, 2015
Back-port of a set of fixes for the conddb core
@cmsbuild cmsbuild merged commit 0554e6d into cms-sw:CMSSW_7_4_X Oct 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants