Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the name of the path HLT_Ele23_WPLoose_Gsf_CentralPFJet30_BTagCVS07_v1 to HLT_Ele23_WPLoose_Gsf_CentralPFJet30_BTagCSV07_v1 (cvs -> csv) #11526

Merged
merged 2 commits into from Oct 4, 2015

Conversation

soureek
Copy link

@soureek soureek commented Sep 28, 2015

The name of one of the back up path for Top:
HLT_Ele23_WPLoose_Gsf_CentralPFJet30_BTagCVS07_v1
is changed to
HLT_Ele23_WPLoose_Gsf_CentralPFJet30_BTagCSV07_v1

(cvs->csv)

in the following files
DQMOffline/Trigger/python/singletopHLTEventDQM_cfi.py
DQMOffline/Trigger/python/topSingleLeptonHLTEventDQM_cfi.py
HLTriggerOffline/Top/python/singletopHLTEventValidation_cfi.py
HLTriggerOffline/Top/python/topSingleLeptonHLTEventValidation_cfi.py

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Soureek89 (Soureek Mitra) for CMSSW_7_6_X.

Soureek_Changes_on_28_09

It involves the following packages:

DQMOffline/Trigger
HLTriggerOffline/Top

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@rociovilar, @trocino, @jhgoh, @battibass this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Sep 28, 2015

please test

@deguio
Copy link
Contributor

deguio commented Sep 28, 2015

@Soureek89
please change the title of this PR to something meaningful for the release notes.

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.

@soureek soureek changed the title Soureek_Changes_on_28_09 Changing the name of the path HLT_Ele23_WPLoose_Gsf_CentralPFJet30_BTagCVS07_v1 to HLT_Ele23_WPLoose_Gsf_CentralPFJet30_BTagCSV07_v1 (cvs -> csv) Sep 28, 2015
@soureek
Copy link
Author

soureek commented Sep 28, 2015

The name of the PR has been changed.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Sep 30, 2015

@Soureek89
please just remove the commented lines. they are anyway available in the git history.
thanks,
F.

@soureek
Copy link
Author

soureek commented Sep 30, 2015

I have removed the commented lines in the 4 relevant files. Please check.

@cmsbuild
Copy link
Contributor

Pull request #11526 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Oct 2, 2015

please test

@deguio
Copy link
Contributor

deguio commented Oct 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

1 similar comment
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 4, 2015
Changing the name of the path HLT_Ele23_WPLoose_Gsf_CentralPFJet30_BTagCVS07_v1 to HLT_Ele23_WPLoose_Gsf_CentralPFJet30_BTagCSV07_v1 (cvs -> csv)
@cmsbuild cmsbuild merged commit 5e7f6c2 into cms-sw:CMSSW_7_6_X Oct 4, 2015
@soureek soureek deleted the Soureek_2809 branch October 6, 2015 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants