Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed inappropriate use of SerialTaskQueue from ClusterShapeLazyGetter #11562

Commits on Sep 29, 2015

  1. Removed inappropriate use of SerialTaskQueue from ClusterShapeLazyGetter

    A SerialTaskQueue was added to ClusterShapeLazyGetter in an attempt
    to make it thread safe. Unfortunately, the implementation was safe
    since the internals of SiPixelClusterShapeCache could be changed
    while another thread was reading the data outside of the queue.
    In addition, performance measurements done using VTune showed
    the fequent calls to SerialTaskQueue were causing a heavy CPU load
    when run with 8 threads.
    The thread safety of SiPixelClusterShapeCache will have to be handled
    in a different way in the future once we start using more than one
    thread per Event.
    Dr15Jones committed Sep 29, 2015
    Copy the full SHA
    5cbb937 View commit details
    Browse the repository at this point in the history