Use std::lower_bound to add/search for userFloats/Ints/Cands/KinResolutions (75X) #11575

lgray · 2015-09-30T14:54:46Z

Backport of #11574.

lgray · 2015-09-30T14:55:24Z

@cmsbuild please test

cmsbuild · 2015-09-30T14:56:17Z

The tests are being triggered in jenkins.

cmsbuild · 2015-09-30T14:56:19Z

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_5_X.

Use std::lower_bound to add/search for userFloats/Ints/Cands/KinResolutions (75X)

It involves the following packages:

DataFormats/PatCandidates

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

lgray · 2015-09-30T15:22:51Z

@slava77 @cvuosalo FYI

cmsbuild · 2015-09-30T21:27:58Z

+1
Tested at: 7d0a343
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11575/8523/summary.html

cmsbuild · 2015-09-30T22:35:47Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11575/8523/summary.html

lgray · 2015-10-01T16:02:23Z

@cmsbuild please test

cmsbuild · 2015-10-01T16:06:58Z

The tests are being triggered in jenkins.

cmsbuild · 2015-10-01T16:07:00Z

Pull request #11575 was updated. @cmsbuild, @vadler, @monttj can you please check and sign again.

cmsbuild · 2015-10-01T18:46:41Z

+1
Tested at: f41fd3c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11575/8553/summary.html

cmsbuild · 2015-10-06T14:43:30Z

-1
Tested at: 7d28b4e
When I ran the RelVals I found an error in the following worklfows:
25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log
----- Begin Fatal Exception 06-Oct-2015 16:04:40 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling RootFileSequenceBase::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/3EF2051A-352A-E511-9B05-002590596498.root'
   Additional Info:
      [a] XrdCl::File::Open(name='root://eoscms//eos/cms/store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/3EF2051A-352A-E511-9B05-002590596498.root?svcClass=default', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] Unable to open file /eos/cms/store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/3EF2051A-352A-E511-9B05-002590596498.root; No such file or directory
' (errno=3011, code=400). No additional data servers were found.
      [b] Last URL tried: root://eoscms:1094//eos/cms/store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/3EF2051A-352A-E511-9B05-002590596498.root?svcClass=default&tried=
      [c] Problematic data server: eoscms:1094
      [d] Disabled source: eoscms:1094
      [e] Input file root://eoscms//eos/cms/store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/3EF2051A-352A-E511-9B05-002590596498.root?svcClass=default could not be opened.
Fallback Input file root://xrootd-cms.infn.it//store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/3EF2051A-352A-E511-9B05-002590596498.root also could not be opened.
Original exception info is above; fallback exception info is below.
      [f] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/3EF2051A-352A-E511-9B05-002590596498.root', flags=0x10, permissions=0660) => error '[FATAL] Redirect limit has been reached' (errno=0, code=306). No additional data servers were found.
      [g] Last URL tried: root://cmsxrootd-site2.fnal.gov:1093//store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/3EF2051A-352A-E511-9B05-002590596498.root?tried=+1213xrootd.ba.infn.it,
      [h] Problematic data server: cmsxrootd-site2.fnal.gov:1093
      [i] Disabled source: cmsxrootd-site2.fnal.gov:1093
      [j] Disabled source: cmsxrootd-site1.fnal.gov:1093
----- End Fatal Exception -------------------------------------------------

50202.0 step2

runTheMatrix-results/50202.0_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50/step2_TTbar_13+TTbar_13+DIGIUP15_PU50+RECOUP15_PU50+HARVESTUP15_PU50.log
----- Begin Fatal Exception 06-Oct-2015 16:09:02 CEST-----------------------
An exception of category 'FallbackFileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
   [2] Calling RootFileSequenceBase::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://xrootd-cms.infn.it//store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/E2FC9C1F-352A-E511-BA06-0025905964A6.root'
   Additional Info:
      [a] XrdCl::File::Open(name='root://eoscms//eos/cms/store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/E2FC9C1F-352A-E511-BA06-0025905964A6.root?svcClass=default', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3011] Unable to open file /eos/cms/store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/E2FC9C1F-352A-E511-BA06-0025905964A6.root; No such file or directory
' (errno=3011, code=400). No additional data servers were found.
      [b] Last URL tried: root://eoscms:1094//eos/cms/store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/E2FC9C1F-352A-E511-BA06-0025905964A6.root?svcClass=default&tried=
      [c] Problematic data server: eoscms:1094
      [d] Disabled source: eoscms:1094
      [e] Input file root://eoscms//eos/cms/store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/E2FC9C1F-352A-E511-BA06-0025905964A6.root?svcClass=default could not be opened.
Fallback Input file root://xrootd-cms.infn.it//store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/E2FC9C1F-352A-E511-BA06-0025905964A6.root also could not be opened.
Original exception info is above; fallback exception info is below.
      [f] XrdCl::File::Open(name='root://xrootd-cms.infn.it//store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/E2FC9C1F-352A-E511-BA06-0025905964A6.root', flags=0x10, permissions=0660) => error '[FATAL] Redirect limit has been reached' (errno=0, code=306). No additional data servers were found.
      [g] Last URL tried: root://cmsxrootd-site1.fnal.gov:1093//store/relval/CMSSW_7_5_0/RelValMinBias_13/GEN-SIM/75X_mcRun2_asymptotic_v1-v1/00000/E2FC9C1F-352A-E511-BA06-0025905964A6.root?tried=+1213llrxrd-redir.in2p3.fr,
      [h] Problematic data server: cmsxrootd-site1.fnal.gov:1093
      [i] Disabled source: xrootd-cms.infn.it:1094
      [j] Disabled source: cmsxrootd-site1.fnal.gov:1093
----- End Fatal Exception -------------------------------------------------

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11575/8635/summary.html

lgray · 2015-10-06T14:47:55Z

@smuzaffar @slava77 Can someone please investigate these the above failure? (seems like MinBias dataset can't be reached...)

slava77 · 2015-10-06T15:00:23Z

it looks like the same workflows are failing in IBs as well.
The subscription should be renewed, I suppose.
I haven't done this before: which CERN should be requested for this case?
the dataset in this case is /RelValMinBias_13/CMSSW_7_5_0-75X_mcRun2_asymptotic_v1-v1/GEN-SIM
I think Shahzad did this before

smuzaffar · 2015-10-06T15:25:13Z

@davidlt , can you please request this dataset?

davidlt · 2015-10-06T15:30:17Z

https://cmsweb.cern.ch/phedex/prod/Request::View?request=491139

I guess it was auto garbage collected or something. Only available in T0 and T1 FNAL Disk cache.

lgray · 2015-10-11T12:39:35Z

@cmsbuild please test

cmsbuild · 2015-10-11T12:41:17Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8755/console

cmsbuild · 2015-10-11T15:44:25Z

+1
Tested at: 7d28b4e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11575/8755/summary.html

cmsbuild · 2015-10-11T17:18:40Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11575/8755/summary.html

davidlt · 2015-10-29T06:00:23Z

18 days and no progress. Is this one still alive?

davidlange6 · 2015-10-29T07:30:18Z

@davidlt - actually its an empty area, so maybe the answer to your question is no.... but in any case, these changes aren't very important for 75x at this point given its scope- I presume they are already in 76x?

lgray · 2015-10-29T08:01:15Z

Yes they are in 76X, 80X.

-L

(Sent from my Nexus 6)
On Oct 29, 2015 08:30, "David Lange" notifications@github.com wrote:

@davidlt https://github.com/davidlt - actually its an empty area, so
maybe the answer to your question is no.... but in any case, these changes
aren't very important for 75x at this point given its scope- I presume they
are already in 76x?

—
Reply to this email directly or view it on GitHub
#11575 (comment).

davidlt · 2015-10-30T05:54:44Z

Should we close this one?

davidlt · 2015-11-03T21:38:08Z

ping

davidlange6 · 2015-11-04T00:42:52Z

instead I'll merge - we will do a bit of HI pp prompt reco with 75x (hopefully)

Use std::lower_bound to add/search for userFloats/Ints/Cands/KinResolutions (75X)

use std::lower_bound to search for userFloats/Ints/Cands/KinResolutions

7d0a343

cmsbuild added this to the Next CMSSW_7_5_X milestone Sep 30, 2015

cmsbuild added analysis-pending pending-signatures tests-pending orp-pending comparison-pending labels Sep 30, 2015

cmsbuild added tests-started and removed tests-pending labels Sep 30, 2015

cmsbuild added tests-approved and removed tests-started labels Sep 30, 2015

cmsbuild added comparison-available and removed comparison-pending labels Sep 30, 2015

throw exception on not finding a userFloat/userInt

f41fd3c

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-approved labels Oct 1, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 1, 2015

cmsbuild added tests-pending tests-started and removed tests-pending labels Oct 6, 2015

cmsbuild added tests-rejected and removed tests-started labels Oct 6, 2015

cmsbuild added tests-pending tests-started and removed tests-rejected tests-pending labels Oct 11, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 11, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 11, 2015

davidlange6 added a commit that referenced this pull request Nov 4, 2015

Merge pull request #11575 from lgray/PATObject_lower_bound_75X

1098496

Use std::lower_bound to add/search for userFloats/Ints/Cands/KinResolutions (75X)

davidlange6 merged commit 1098496 into cms-sw:CMSSW_7_5_X Nov 4, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use std::lower_bound to add/search for userFloats/Ints/Cands/KinResolutions (75X) #11575

Use std::lower_bound to add/search for userFloats/Ints/Cands/KinResolutions (75X) #11575

lgray commented Sep 30, 2015

lgray commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

lgray commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

lgray commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 6, 2015

lgray commented Oct 6, 2015

slava77 commented Oct 6, 2015

smuzaffar commented Oct 6, 2015

davidlt commented Oct 6, 2015

lgray commented Oct 11, 2015

cmsbuild commented Oct 11, 2015

cmsbuild commented Oct 11, 2015

cmsbuild commented Oct 11, 2015

davidlt commented Oct 29, 2015

davidlange6 commented Oct 29, 2015

lgray commented Oct 29, 2015

davidlt commented Oct 30, 2015

davidlt commented Nov 3, 2015

davidlange6 commented Nov 4, 2015

Use std::lower_bound to add/search for userFloats/Ints/Cands/KinResolutions (75X) #11575

Use std::lower_bound to add/search for userFloats/Ints/Cands/KinResolutions (75X) #11575

Conversation

lgray commented Sep 30, 2015

lgray commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

lgray commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

cmsbuild commented Sep 30, 2015

lgray commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 1, 2015

cmsbuild commented Oct 6, 2015

lgray commented Oct 6, 2015

slava77 commented Oct 6, 2015

smuzaffar commented Oct 6, 2015

davidlt commented Oct 6, 2015

lgray commented Oct 11, 2015

cmsbuild commented Oct 11, 2015

cmsbuild commented Oct 11, 2015

cmsbuild commented Oct 11, 2015

davidlt commented Oct 29, 2015

davidlange6 commented Oct 29, 2015

lgray commented Oct 29, 2015

davidlt commented Oct 30, 2015

davidlt commented Nov 3, 2015

davidlange6 commented Nov 4, 2015