Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central bunch spacing producer for 76x #11576

Merged
merged 6 commits into from Oct 5, 2015

Conversation

davidlange6
Copy link
Contributor

#11544 but for 76x.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @davidlange6 (David Lange) for CMSSW_7_6_X.

Central bunch spacing producer for 76x

It involves the following packages:

Configuration/StandardSequences
RecoEgamma/EgammaTools
RecoLocalCalo/EcalRecProducers
RecoLuminosity/LumiProducer
RecoParticleFlow/PFClusterProducer
Validation/Configuration

@civanch, @cvuosalo, @mdhildreth, @cmsbuild, @franzoni, @deguio, @slava77, @danduggan, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @mmarionncern, @Sam-Harper, @argiro, @makortel, @GiacomoSguazzoni, @rovere, @lgray, @Martin-Grunewald, @cerati, @VinInn, @dgulhan, @bachtis this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor Author

cmsbuild, please test

@deguio
Copy link
Contributor

deguio commented Sep 30, 2015

please test

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

@slava77
Copy link
Contributor

slava77 commented Oct 1, 2015

I checked this locally including run2 relval 2015B and 2015C data workflows and confirm no differences.
The only problem is the cout.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

@civanch
Copy link
Contributor

civanch commented Oct 2, 2015

@davidlange6 , in BunchSpacingProducer uncontrolled std::cout is left...

@davidlange6
Copy link
Contributor Author

yes, I’m aware

On Oct 2, 2015, at 10:40 AM, Vladimir Ivantchenko notifications@github.com wrote:

@davidlange6 , in BunchSpacingProducer uncontrolled std::cout is left...


Reply to this email directly or view it on GitHub.

davidlange6 added a commit that referenced this pull request Oct 5, 2015
Central bunch spacing producer for 76x
@davidlange6 davidlange6 merged commit 118d7b0 into cms-sw:CMSSW_7_6_X Oct 5, 2015
@smuzaffar
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants