Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add member function in FillInfo to check the injection scheme for 25 ns. #11588

Merged
merged 1 commit into from Oct 5, 2015

Conversation

diguida
Copy link
Contributor

@diguida diguida commented Oct 1, 2015

This adds a dummy test for the bunch spacing information: it returns true if the injection scheme string starts with 25ns.
The correct check to be done is to test the bitset and look for "holes".

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

A new Pull Request was created by @diguida (Salvatore Di Guida) for CMSSW_7_6_X.

Add member function in FillInfo to check the injection scheme for 25 ns.

It involves the following packages:

CondFormats/RunInfo

@diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich can you please review it and eventually sign? Thanks.
@apfeiffer1 this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@diguida
Copy link
Contributor Author

diguida commented Oct 1, 2015

please test

@diguida
Copy link
Contributor Author

diguida commented Oct 1, 2015

@slava77 @davidlange6 this is the minimal step to allow people to check the bunch spacing.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

The tests are being triggered in jenkins.

@ggovi
Copy link
Contributor

ggovi commented Oct 1, 2015

+1

@diguida
Copy link
Contributor Author

diguida commented Oct 1, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

Pull request #11588 was updated. @diguida, @cerminar, @cmsbuild, @franzoni, @ggovi, @mmusich can you please check and sign again.

@diguida
Copy link
Contributor Author

diguida commented Oct 1, 2015

please test

@diguida
Copy link
Contributor Author

diguida commented Oct 1, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

@diguida
Copy link
Contributor Author

diguida commented Oct 1, 2015

@ggovi ping :-)

@ggovi
Copy link
Contributor

ggovi commented Oct 5, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 5, 2015
Add member function in FillInfo to check the injection scheme for 25 ns.
@cmsbuild cmsbuild merged commit 36cb33d into cms-sw:CMSSW_7_6_X Oct 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants