Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make average Fed Occupancy a TProfile #11597

Merged
merged 2 commits into from Oct 28, 2015
Merged

Make average Fed Occupancy a TProfile #11597

merged 2 commits into from Oct 28, 2015

Conversation

fioriNTU
Copy link
Contributor

@fioriNTU fioriNTU commented Oct 1, 2015

Having the FED ocuupancy as TProfile is the easist way to merge histos in harvesting phase, plus I removed commented code

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

A new Pull Request was created by @fioriNTU for CMSSW_7_4_X.

Make average Fed Occupancy a TProfile

It involves the following packages:

DQM/SiPixelMonitorDigi

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
@threus this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Oct 2, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

Pull request #11597 was updated. @cmsbuild, @danduggan, @vanbesien, @deguio can you please check and sign again.

@deguio
Copy link
Contributor

deguio commented Oct 7, 2015

is there a correspondent PR for 75?
thanks,
F.

@fioriNTU
Copy link
Contributor Author

fioriNTU commented Oct 7, 2015

Yep, the same changes are in #11488 , it was still Open so I didn't
submit a new PR, I updated the existing one.

Ciao,
FF

Il 07/10/2015 13.43, Federico De Guio ha scritto:

is there a correspondent PR for 75?
thanks,
F.


Reply to this email directly or view it on GitHub
#11597 (comment).


Questa e-mail è stata controllata per individuare virus con Avast antivirus.
https://www.avast.com/antivirus

@deguio
Copy link
Contributor

deguio commented Oct 7, 2015

I don't see them..
thanks,
F.

@fioriNTU
Copy link
Contributor Author

fioriNTU commented Oct 7, 2015

Sorry Federico, my fault, the right PR is #11186.

Ciao,
FF

Il 07/10/2015 16.09, Federico De Guio ha scritto:

I don't see them..
thanks,
F.


Reply to this email directly or view it on GitHub
#11597 (comment).


Questa e-mail è stata controllata per individuare virus con Avast antivirus.
https://www.avast.com/antivirus

@deguio
Copy link
Contributor

deguio commented Oct 14, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8813/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 28, 2015
Make average Fed Occupancy a TProfile
@cmsbuild cmsbuild merged commit cfd5ee5 into cms-sw:CMSSW_7_4_X Oct 28, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants