Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixing Modules should be of type 'one' #1160

Merged
merged 1 commit into from Oct 24, 2013

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Oct 24, 2013

This pull request makes the mixing module and the data mixing module type one modules, rather than legacy modules. Tested with checkdeps -a and the full relval matrix.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_0_X.

Mixing Modules should be of type 'one'

It involves the following packages:

SimCalorimetry/EcalTestBeam
SimTracker/SiStripDigitizer
SimCalorimetry/HcalSimProducers
SimCalorimetry/HcalTestBeam
SimCalorimetry/CastorSim
SimCalorimetry/EcalSimProducers
SimGeneral/TrackingAnalysis
SimGeneral/MixingModule
FastSimulation/Tracking
Mixing/Base
SimTracker/SiPixelDigitizer

@smuzaffar, @civanch, @nclopezo, @lveldere, @mdhildreth, @giamman can you please review it and eventually sign? Thanks.
@cerati, @GiacomoSguazzoni, @rovere this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@ktf you are the release manager for this.

@giamman
Copy link
Contributor

giamman commented Oct 24, 2013

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

@nclopezo
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next IBs unless changes or unless it breaks tests. @ktf can you please take care of it?

ktf added a commit that referenced this pull request Oct 24, 2013
Multithreaded framework -- Mixing Modules should be of type 'one'
@ktf ktf merged commit 770a550 into cms-sw:CMSSW_7_0_X Oct 24, 2013
@Dr15Jones
Copy link
Contributor

This will only work properly if none of the functions called by the module use a shared resource. I'm not convinced we know that yet.

@wmtan wmtan deleted the MixingModuleIsTypeOne branch October 24, 2013 15:59
jfernan2 pushed a commit to jfernan2/cmssw that referenced this pull request Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants