Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GEM geometry v7 and v7_10deg version to gemGeometryCustoms.py #11602

Merged
merged 3 commits into from Oct 4, 2015

Conversation

geonmo
Copy link
Contributor

@geonmo geonmo commented Oct 1, 2015

  1. "gemGeometryCustoms" script is related to changing geometry xml files.
    • On this PR, geometry GE21 v7 and v7_10deg version is added.
  2. To fix GEMSpec's strip information is required for v7_10deg
    • Number of strips : 384->192

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

A new Pull Request was created by @geonmo (Geonmo Ryu) for CMSSW_7_6_X.

Add GEM geometry v7 and v7_10deg version to gemGeometryCustoms.py

It involves the following packages:

Geometry/GEMGeometry
Geometry/GEMGeometryBuilder

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Oct 1, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 1, 2015

@geonmo
Copy link
Contributor Author

geonmo commented Oct 2, 2015

@ianna Could you check this PR?

@ianna
Copy link
Contributor

ianna commented Oct 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@geonmo
Copy link
Contributor Author

geonmo commented Oct 2, 2015

@davidlange6 Hello! Could you check and merge this PR to 76X_IB?

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 4, 2015
Add GEM geometry v7 and v7_10deg version to gemGeometryCustoms.py
@cmsbuild cmsbuild merged commit f807f46 into cms-sw:CMSSW_7_6_X Oct 4, 2015
@geonmo geonmo deleted the gemGeometryScripts branch October 4, 2015 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants