fix ES unpacker when the 2nd OptoRX is diabled, but the 1t and 3rd Op…

[cmkuo]

This is to fix the problem when the second ES OptoRX is disabled, but the first and third OptoRX are enabled in the ES unpacker. The problem would cause the data in third OptoRX are not unpacked.

[cmsbuild]

A new Pull Request was created by @cmkuo for CMSSW_7_5_X.

fix ES unpacker when the 2nd OptoRX is diabled, but the 1t and 3rd Op

It involves the following packages:

EventFilter/ESRawToDigi

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[smuzaffar]

ignore this comment

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 676c423
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11615/8587/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11615/8587/summary.html

[cvuosalo]

+1

For #11615 676c423

Fixing an ES unpacker bug where the third OptoRX is missed in certain cases. #11613 and #11614 are the 74X and 76X versions of this PR, and they have already been approved by Reco.

The code changes are satisfactory, and Jenkins tests against baseline CMSSW_7_5_X_2015-10-01-2300 show no significant differences. Test results in #11613 show the expected changes from this fix.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8700/console

[cmsbuild]

Pull request #11615 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

[cmsbuild]

+1
Tested at: 9a87049
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11615/8700/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11615/8700/summary.html

[slava77]

+1

for #11615 9a87049

• same changes since the last sign off of this PR were added as in 76X update improve ES unpacker #11693 : 676c423...9a87049
• jenkins tests pass and comparisons with the baseline show no difference

@cvuosalo is offline today, I took the liberty to sign off in case there is an early 75X build

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1