Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda:Run2-hcx35 Testing HGCal Geometry and Topology #11622

Merged
merged 1 commit into from Oct 4, 2015

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Oct 2, 2015

Adding the functionality of closed PR 11556

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

A new Pull Request was created by @bsunanda for CMSSW_7_6_X.

bsunanda:Run2-hcx35 Testing HGCal Geometry and Topology

It involves the following packages:

Geometry/CaloTopology
Geometry/EcalSimData
Geometry/HGCalCommonData

@cmsbuild, @civanch, @Dr15Jones, @ianna, @mdhildreth can you please review it and eventually sign? Thanks.
@ghellwig, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Oct 2, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

@ianna
Copy link
Contributor

ianna commented Oct 2, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 2, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@lgray
Copy link
Contributor

lgray commented Oct 3, 2015

@davidlange6 FYI it would be pretty useful for us (HGCal software community) to get as much as possible in with 7_6_0. This way we have a solid (and at least mechanically validated) base for the 7_7_0_preX releases.

@davidlange6
Copy link
Contributor

why all the special mails?This PR has been signed for 0 working days…

On Oct 3, 2015, at 2:22 PM, Ianna Osborne notifications@github.com wrote:

@davidlange6 I agree with @lgray, besides this PR is unrelated to anything else except for HGCal in 76x.


Reply to this email directly or view it on GitHub.

@lgray
Copy link
Contributor

lgray commented Oct 3, 2015

@davidlange6 Just stating my concerns/interests and it's a rather big project.
I can make a script to ping you after one day instead?

I guess @ianna agrees? Anyway, indeed it is Saturday.

@davidlange6
Copy link
Contributor

+1
typically no special attention is needed for integration in development releases...

cmsbuild added a commit that referenced this pull request Oct 4, 2015
bsunanda:Run2-hcx35 Testing HGCal Geometry and Topology
@cmsbuild cmsbuild merged commit 10cf006 into cms-sw:CMSSW_7_6_X Oct 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants