Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scouting producers now ignore missing input collections #11627

Merged
merged 1 commit into from Oct 9, 2015
Merged

Scouting producers now ignore missing input collections #11627

merged 1 commit into from Oct 9, 2015

Conversation

duanders
Copy link
Contributor

@duanders duanders commented Oct 4, 2015

HLTScoutingCaloProducer and HLTScoutingPFProducer no longer return when they fail to find an input collection. Instead they pack whatever information is available and ignore the missing collection.

This change is needed to complete the integration of the latest scouting trigger paths into the HLT menu.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 4, 2015

A new Pull Request was created by @duanders (Dustin Anderson) for CMSSW_7_4_X.

Scouting producers now ignore missing input collections

It involves the following packages:

HLTrigger/JetMET

@Martin-Grunewald, @perrotta, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

We'd need PRs for 75X and 76X as well!

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 5, 2015

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 9, 2015
Scouting producers now ignore missing input collections
@cmsbuild cmsbuild merged commit 10a0c52 into cms-sw:CMSSW_7_4_X Oct 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants