Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove ref to testCondDBDict which is not part of this package any more #11628

Merged
merged 2 commits into from Oct 5, 2015
Merged

remove ref to testCondDBDict which is not part of this package any more #11628

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8efe592
remove ref to testCondDBDict which is not part of this package any more
smuzaffar Oct 5, 2015
c919e61
generate test dictionary
smuzaffar Oct 5, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions CondCore/CondDB/test/BuildFile.xml
View file
Open in desktop
Expand Up @@ -6,8 +6,9 @@
<use name="FWCore/PluginManager"/>
<use name="FWCore/Utilities"/>

<library file="" name="testCondDBDict"/>

<bin file="testReadWritePayloads.cpp" name="testReadWritePayloads">
<lib name="testCondDBDict"/>
</bin>

<bin file="testConditionDatabase_1.cpp" name="testConditionDatabase_1">
Expand All @@ -17,11 +18,9 @@
</bin>

<bin file="testRootStreaming.cpp" name="testRootStreaming">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does SCRAM automatically link the dictionary to everything, or we need to bring back this statement?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think root is going to take care of it by reading the testCondDBDict_xr.rootmap file ...right? at least unit tests run locally without explicitly linking to testCondDBDict

<lib name="testCondDBDict"/>
</bin>

<bin file="testPayloadProxy.cpp" name="testPayloadProxy">
<lib name="testCondDBDict"/>
</bin>

<bin file="testFrontier.cpp" name="testFrontier">
Expand Down