Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set reco::CandViewCandViewAssociation as transient #11647

Merged
merged 1 commit into from Oct 8, 2015
Merged

set reco::CandViewCandViewAssociation as transient #11647

merged 1 commit into from Oct 8, 2015

Conversation

smuzaffar
Copy link
Contributor

In order to enable new configuration/build rules with checks for Class Transients, this change need to go in.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for CMSSW_7_6_X.

set reco::CandViewCandViewAssociation as transient

It involves the following packages:

DataFormats/Candidate

@cmsbuild, @cvuosalo, @vadler, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 6, 2015

@slava77
Copy link
Contributor

slava77 commented Oct 7, 2015

+1

for #11647 6f0a5ec

  • technical change: views are not persisted
  • jenkins tests pass and comparisons with baseline show no differences

davidlange6 added a commit that referenced this pull request Oct 8, 2015
…2300

set reco::CandViewCandViewAssociation as transient
@davidlange6 davidlange6 merged commit fa9d97b into cms-sw:CMSSW_7_6_X Oct 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants