Forward port HGCalRecAlgos/Producers from CMSSW_6_2_0_SLHC26_patch3 (76X) #11651

lgray · 2015-10-06T13:04:14Z

Add in local reconstruction modules for the most basic version of the HGCal local reconstruction.

No workflows or RECO sequences are activated yet, so no changes expected/observed in testing.

lgray · 2015-10-06T13:04:37Z

@bsunanda FYI

lgray · 2015-10-06T13:04:44Z

@cmsbuild please test

cmsbuild · 2015-10-06T13:06:10Z

The tests are being triggered in jenkins.

cmsbuild · 2015-10-06T13:06:12Z

A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_6_X.

Forward port HGCalRecAlgos/Producers from CMSSW_6_2_0_SLHC26_patch3 (76X)

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @pfs, @kpedro88, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

cmsbuild · 2015-10-06T15:02:56Z

-1
Tested at: 7b6a476
I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 8 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-05-2300/src/RecoLocalCalo/HGCalRecProducers/plugins/HGCalUncalibRecHitProducer.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-05-2300/src/RecoLocalCalo/HGCalRecProducers/plugins/HGCalRecHitWorkerSimple.cc 
>> Compiling edm plugin /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-05-2300/src/RecoLocalCalo/HGCalRecProducers/plugins/HGCalUncalibRecHitWorkerWeights.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-05-2300/src/FWCore/Version/src/GetFileFormatVersion.cc 
>> Compiling  /tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-05-2300/src/FWCore/Version/src/GetReleaseVersion.cc 
/tmp/cmsbuild/workspace/ib-any-integration/CMSSW_7_6_X_2015-10-05-2300/src/RecoLocalCalo/HGCalRecProducers/test/HGCalLocalRecoTask.cc:225:43: error: unused variable 'myRecHit' [-Werror,-Wunused-variable]
      HGCRecHitCollection::const_iterator myRecHit = HGCEERecHit->find(HGCEEid);
                                          ^
1 error generated.
gmake: **\* [tmp/slc6_amd64_gcc493/src/RecoLocalCalo/HGCalRecProducers/test/testHGCalLocalReco/HGCalLocalRecoTask.o] Error 1
>> Compile sequence completed for CMSSW CMSSW_7_6_X_2015-10-05-2300

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11651/8637/summary.html

lgray · 2015-10-06T15:28:28Z

@slava77 taking the time to migrate to tokens and stream modules for this one as well.

slava77 · 2015-10-06T15:36:19Z

MT-aware modules and consumes migration should be done first

slava77 · 2015-10-06T15:36:40Z

It would be good to have a working config file as well.

cmsbuild · 2015-10-06T15:59:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11651/8637/summary.html

cmsbuild · 2015-10-06T16:11:41Z

Pull request #11651 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

lgray · 2015-10-06T16:12:20Z

@cmsbuild please test

lgray · 2015-10-06T16:13:50Z

@slava77 Configs are the exact ones used in SLHC26_patch3. The modules are now updated to thread-aware modules and consumes. We will need to wait a bit longer before the reco customizations are movable.

cmsbuild · 2015-10-06T16:16:29Z

The tests are being triggered in jenkins.

lgray · 2015-10-09T13:31:32Z

@cmsbuild please test

cmsbuild · 2015-10-09T13:31:35Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8724/console

cmsbuild · 2015-10-09T13:31:36Z

Pull request #11651 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

cmsbuild · 2015-10-09T14:42:14Z

+1
Tested at: 68b70e0
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11651/8720/summary.html

cmsbuild · 2015-10-09T15:07:48Z

+1
Tested at: b6cc905
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11651/8724/summary.html

cmsbuild · 2015-10-09T15:40:07Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11651/8720/summary.html

cmsbuild · 2015-10-09T16:28:48Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11651/8724/summary.html

slava77 · 2015-10-09T19:01:28Z

RecoLocalCalo/HGCalRecAlgos/interface/HGCalRecHitSimpleAlgo.h

+
+  /// Compute parameters
+  virtual HGCRecHit makeRecHit(const HGCUncalibratedRecHit& uncalibRH,
+                               const uint32_t& flags = 0) const override {


const uint32_t& the & still remains.
Any good reason?

slava77 · 2015-10-09T19:16:53Z

+1

for #11651 b6cc905

changes in the code in line with the PR description
jenkins tests pass in compilation and code QA
tested locally in CMSSW_7_6_X_2015-10-08-2300-1100 using the supplied RecoLocalCalo/HGCalRecProducers/test/testHGCalRecoLocal_cfg.py : it runs and the producers don't consume much CPU (the implementation is rather simple: so, they shouldn't)

cmsbuild · 2015-10-09T19:21:45Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 · 2015-10-11T14:31:39Z

+1

Forward port HGCalRecAlgos/Producers from CMSSW_6_2_0_SLHC26_patch3 (76X)

cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 6, 2015

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending comparison-pending labels Oct 6, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 6, 2015

cmsbuild added tests-rejected and removed tests-started labels Oct 6, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 6, 2015

lgray force-pushed the hgcal_rechit_modules branch from 7b6a476 to f0cec8e Compare October 6, 2015 16:11

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-rejected labels Oct 6, 2015

kill clang warning

b6cc905

cmsbuild added tests-pending comparison-pending and removed comparison-available tests-started labels Oct 9, 2015

cmsbuild added tests-started and removed tests-pending labels Oct 9, 2015

cmsbuild added tests-approved and removed tests-started labels Oct 9, 2015

cmsbuild added comparison-available and removed comparison-pending labels Oct 9, 2015

slava77 reviewed Oct 9, 2015
View reviewed changes

cmsbuild added reconstruction-approved fully-signed and removed pending-signatures reconstruction-pending labels Oct 9, 2015

cmsbuild added orp-approved and removed orp-pending labels Oct 11, 2015

cmsbuild added a commit that referenced this pull request Oct 11, 2015

Merge pull request #11651 from lgray/hgcal_rechit_modules

2223484

Forward port HGCalRecAlgos/Producers from CMSSW_6_2_0_SLHC26_patch3 (76X)

cmsbuild merged commit 2223484 into cms-sw:CMSSW_7_6_X Oct 11, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Forward port HGCalRecAlgos/Producers from CMSSW_6_2_0_SLHC26_patch3 (76X) #11651

Forward port HGCalRecAlgos/Producers from CMSSW_6_2_0_SLHC26_patch3 (76X) #11651

lgray commented Oct 6, 2015

lgray commented Oct 6, 2015

lgray commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

lgray commented Oct 6, 2015

slava77 commented Oct 6, 2015

slava77 commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

lgray commented Oct 6, 2015

lgray commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

lgray commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

slava77 Oct 9, 2015

slava77 commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

davidlange6 commented Oct 11, 2015

Forward port HGCalRecAlgos/Producers from CMSSW_6_2_0_SLHC26_patch3 (76X) #11651

Forward port HGCalRecAlgos/Producers from CMSSW_6_2_0_SLHC26_patch3 (76X) #11651

Conversation

lgray commented Oct 6, 2015

lgray commented Oct 6, 2015

lgray commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

lgray commented Oct 6, 2015

slava77 commented Oct 6, 2015

slava77 commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

lgray commented Oct 6, 2015

lgray commented Oct 6, 2015

cmsbuild commented Oct 6, 2015

lgray commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

slava77 Oct 9, 2015

Choose a reason for hiding this comment

slava77 commented Oct 9, 2015

cmsbuild commented Oct 9, 2015

davidlange6 commented Oct 11, 2015