Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[74X] JER integration into conditions database #11664

Closed
wants to merge 4 commits into from

Conversation

blinkseb
Copy link
Contributor

@blinkseb blinkseb commented Oct 7, 2015

This PR is a backport of #10448 for CMSSW 7.4.x

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

A new Pull Request was created by @blinkseb (Sébastien Brochet) for CMSSW_7_4_X.

[74X] JER integration into conditions database

It involves the following packages:

CondCore/JetMETPlugins
CondCore/Utilities
CondFormats/DataRecord
CondFormats/JetMETObjects
JetMETCorrections/Modules

@diguida, @cerminar, @monttj, @cmsbuild, @franzoni, @ggovi, @vadler, @mmusich can you please review it and eventually sign? Thanks.
@ghellwig, @apfeiffer1, @ahinzmann, @rappoccio, @mmarionncern, @TaiSakuma, @jdolen, @nhanvtran, @schoef, @mariadalfonso this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Oct 7, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

@ggovi
Copy link
Contributor

ggovi commented Nov 4, 2015

+1

@mmusich
Copy link
Contributor

mmusich commented Nov 4, 2015

+1

@ggovi
Copy link
Contributor

ggovi commented Nov 30, 2015

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2016

Pull request #11664 was updated. @diguida, @cerminar, @monttj, @cmsbuild, @franzoni, @ggovi, @vadler, @mmusich, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Jan 12, 2016

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/10465/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@ggovi
Copy link
Contributor

ggovi commented Feb 2, 2016

+1

@mmusich
Copy link
Contributor

mmusich commented Feb 3, 2016

+1

@monttj
Copy link
Contributor

monttj commented Nov 14, 2016

+1

@cmsbuild
Copy link
Contributor

Pull request #11664 was updated. @cvuosalo, @slava77, @davidlange6 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Nov 14, 2016

It looks like some recent changes in package categories now added need for reconstruction signature.

Before spending much time on this, please explain why this PR is still needed. Which analyses still use 74X.
Last 74X release was needed 10 months ago.
@blinkseb if this PR is not needed in 74X, please close it.

@blinkseb
Copy link
Contributor Author

Looks like it's indeed no longer needed since it's in 7.6.x anyway. Closing this one, thanks.

@blinkseb blinkseb closed this Nov 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants