Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace LinkDef file witl XML selection file in PhysicsTools/TagAndProbe #11680

Merged

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Oct 7, 2015

It has been decided to replace LinkDef files with XML selection files.
This PR does this for the LinkDef files that were in PhysicsTools/TagAndProbe

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 7, 2015

A new Pull Request was created by @wmtan for CMSSW_7_6_X.

Replace LinkDef file witl XML selection file in PhysicsTools/TagAndProbe

It involves the following packages:

PhysicsTools/TagAndProbe

@cmsbuild, @vadler, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@smuzaffar
Copy link
Contributor

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8684/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

-1

Tested at: f12b9c3
I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:50nsGRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_50nsGRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_50ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_50nsGRun_DATA.root --fileout file:RelVal_Raw_50nsGRun_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 10:14:48 2015-date Thu Oct 8 10:10:32 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 10:24:58 2015-date Thu Oct 8 10:21:35 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 10:33:21 2015-date Thu Oct 8 10:27:25 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11680/8684/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

@wmtan
Copy link
Contributor Author

wmtan commented Oct 8, 2015

@cmsbuild The three failing add-on tests fail in the base IB, so the failures are not caused by this PR.
Please mark the tests as approved.

@wmtan
Copy link
Contributor Author

wmtan commented Oct 9, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8733/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

@wmtan
Copy link
Contributor Author

wmtan commented Oct 9, 2015

@vadler, @monttj
Please sign or provide a reason for not signing.

davidlange6 added a commit that referenced this pull request Oct 26, 2015
…ndProbe

Replace LinkDef file witl XML selection file in PhysicsTools/TagAndProbe
@davidlange6 davidlange6 merged commit a7a0ed3 into cms-sw:CMSSW_7_6_X Oct 26, 2015
@wmtan wmtan deleted the ReplaceLinkDefInPhysicsToolsTagAndProbe branch October 27, 2015 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants