Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heavy ion common alignment producer 76 x #11698

Closed

Conversation

jrcastle
Copy link
Contributor

@jrcastle jrcastle commented Oct 8, 2015

This pull request includes the addition of several new common alignment AlCaReco producers that will be used on heavy ion data. Additional files edited include these producers into AlCa streams.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

A new Pull Request was created by @jrcastle (James Castle) for CMSSW_7_6_X.

Heavy ion common alignment producer 76 x

It involves the following packages:

Alignment/CommonAlignmentProducer
Configuration/EventContent
Configuration/StandardSequences
DQMOffline/Alignment

@diguida, @danduggan, @cerminar, @cmsbuild, @franzoni, @deguio, @mmusich, @vanbesien, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @pakhotin, @frmeier, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @tlampen, @mschrode, @cerati, @mmusich, @dgulhan, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mmusich
Copy link
Contributor

mmusich commented Oct 8, 2015

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8707/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

-1

Tested at: f373919
I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:50nsGRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_50nsGRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1_50ns --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_50nsGRun_DATA.root --fileout file:RelVal_Raw_50nsGRun_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 20:45:41 2015-date Thu Oct 8 20:41:28 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 20:54:27 2015-date Thu Oct 8 20:51:30 2015 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --customise=SLHCUpgradeSimulations/Configuration/postLS1Customs.customisePostLS1 --magField 38T_PostLS1 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Thu Oct 8 21:00:33 2015-date Thu Oct 8 20:56:16 2015 s - exit: 16640

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11698/8707/summary.html

@cmsbuild
Copy link
Contributor

Pull request #11698 was updated. @diguida, @danduggan, @boudoul, @franzoni, @cerminar, @fabozzi, @cmsbuild, @srimanob, @deguio, @mmusich, @vanbesien, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor

mmusich commented Oct 29, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9333/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@fabozzi
Copy link
Contributor

fabozzi commented Nov 1, 2015

+1

@mmusich
Copy link
Contributor

mmusich commented Nov 2, 2015

+1

@mmusich
Copy link
Contributor

mmusich commented Nov 2, 2015

@deguio @vanbesien can you please check and sign again?

@deguio
Copy link
Contributor

deguio commented Nov 2, 2015

+1

@boudoul
Copy link
Contributor

boudoul commented Nov 3, 2015

Hi @jrcastle , all, I guess that this should also go to 75X since we will reconstruct HI data in 75X , any though on this?

@mmusich
Copy link
Contributor

mmusich commented Nov 3, 2015

@boudoul of course it is. And indeed it is in #12030 now suprerseded by #12213 (as just discussed at the ORP). Hope this helps.

@boudoul
Copy link
Contributor

boudoul commented Nov 3, 2015

oh ok, was lost between closed, superseeding PRs etc... , perfect, thanks

@mmusich
Copy link
Contributor

mmusich commented Nov 3, 2015

@boudoul this happened because adding the new producers in the relval matrix required changing the AlCaReco Trigger bits in Global Tag thefore the changes are coupled.

@davidlange6
Copy link
Contributor

@mmusich - sorry I didn't notice during the ORP- being a new alca producer this is needed only for 80x at this point I think

@mmusich
Copy link
Contributor

mmusich commented Jan 5, 2016

@davidlange6 that's fine, there is no real use case for it in 76X

@davidlange6
Copy link
Contributor

I am cleaning up the 76x queue aside from things for analysis workflows. I'm closing this pull request, please make sure the PR is in 80x. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants