Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cryptic assert with informative exception for missing Wrapper dictionary #11703

Merged
merged 1 commit into from Oct 9, 2015

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Oct 8, 2015

If an attempt is made to produce a product whose wrapped class (edm::Wrapper) does not have a dictionary, a cryptic assert resulted. This cryptic assert could also occur for other reasons.
This simple PR replaces the cryptic assert with an informative exception, which in the above case is a missing dictionary exception. This PR also fixes another minor problem. If TypeWithDict::name() or any related function was used to get the name of a class that has no dictionary, "dummyType" was returned, rather than the correct name of the class.
This problem is ROOT6 specific, but it also occurs in CMSSW_7_5_X. This fix can be back ported to 7_5_X if needed. This problem does not directly affect 7_4_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

A new Pull Request was created by @wmtan for CMSSW_7_6_X.

Replace cryptic assert with informative exception for missing Wrapper dictionary

It involves the following packages:

FWCore/Utilities

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

please test

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8711/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 8, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs after it passes the integration tests. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 9, 2015
Replace cryptic assert with informative exception for missing Wrapper dictionary
@cmsbuild cmsbuild merged commit 1ef860f into cms-sw:CMSSW_7_6_X Oct 9, 2015
@wmtan wmtan deleted the ReplaceCrypticAssert branch October 14, 2015 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants