Fix the duplicated HF channels

[lihux25]

Throw a LogError is this is found and an empty HF digi collection is put into event

(ref to PR #11702)

[cmsbuild]

A new Pull Request was created by @lihux25 (Hongxuan Liu) for CMSSW_7_5_X.

Fix the duplicated HF channels

It involves the following packages:

EventFilter/HcalRawToDigi

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8712/console

[cmsbuild]

+1
Tested at: a96d553
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11705/8712/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11705/8712/summary.html

[slava77]

+1

for #11705 a96d553

• change to fix the HF output (make no output) if data is corrupted on input; done to solve a crash reported in https://hypernews.cern.ch/HyperNews/CMS/get/recoDevelopment/1390.html
  • the same changes as in 74X Fix the duplicated HF channels #11702
• jenkins tests pass and comparisons with baseline show no differences.
• tests with bad inputs from 258177 were not repeated; relying on 74X tests here

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_5_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

[davidlange6]

+1