New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bsunanda: Run2-hcx40 Update the hit validation package to match Phase2 simulation #11711
Conversation
A new Pull Request was created by @bsunanda for CMSSW_7_6_X. bsunanda: Run2-hcx40 Update the hit validation package to match Phase2 simulation It involves the following packages: Validation/HcalHits @cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks. |
I could not push PR 11634 after removing merge conflict. I tried several times and asked for help. So I am making a fresh PR on the top of the latest IB. From: cmsbuild [notifications@github.com] A new Pull Request was created by @bsunandahttps://github.com/bsunanda for CMSSW_7_6_X. bsunanda: Run2-hcx40 Update the hit validation package to match Phase2 simulation It involves the following packages: Validation/HcalHits @cmsbuildhttps://github.com/cmsbuild, @dandugganhttps://github.com/danduggan, @vanbesienhttps://github.com/vanbesien, @deguiohttps://github.com/deguio can you please review it and eventually sign? Thanks. — |
@cmsbuild Please initiate the tests |
please test |
The tests are being triggered in jenkins. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar |
+1 |
bsunanda: Run2-hcx40 Update the hit validation package to match Phase2 simulation
This request replaces PR 11634 which could not be merged with the last updates to this.