Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bsunanda: Run2-hcx40 Update the hit validation package to match Phase2 simulation #11711

Merged
merged 1 commit into from Oct 16, 2015

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Oct 9, 2015

This request replaces PR 11634 which could not be merged with the last updates to this.

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

A new Pull Request was created by @bsunanda for CMSSW_7_6_X.

bsunanda: Run2-hcx40 Update the hit validation package to match Phase2 simulation

It involves the following packages:

Validation/HcalHits

@cmsbuild, @danduggan, @vanbesien, @deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@bsunanda
Copy link
Contributor Author

bsunanda commented Oct 9, 2015

I could not push PR 11634 after removing merge conflict. I tried several times and asked for help. So I am making a fresh PR on the top of the latest IB.
@cmsbuild Could you initiate the tests at the earliest


From: cmsbuild [notifications@github.com]
Sent: 09 October 2015 09:11
To: cms-sw/cmssw
Cc: Sunanda Banerjee
Subject: Re: [cmssw] bsunanda: Run2-hcx40 Update the hit validation package to match Phase2 simulation (#11711)

A new Pull Request was created by @bsunandahttps://github.com/bsunanda for CMSSW_7_6_X.

bsunanda: Run2-hcx40 Update the hit validation package to match Phase2 simulation

It involves the following packages:

Validation/HcalHits

@cmsbuildhttps://github.com/cmsbuild, @dandugganhttps://github.com/danduggan, @vanbesienhttps://github.com/vanbesien, @deguiohttps://github.com/deguio can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@deganohttps://github.com/degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.


Reply to this email directly or view it on GitHubhttps://github.com//pull/11711#issuecomment-146774717.

@bsunanda
Copy link
Contributor Author

bsunanda commented Oct 9, 2015

@cmsbuild Please initiate the tests

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8722/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 9, 2015

@deguio
Copy link
Contributor

deguio commented Oct 15, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 16, 2015
bsunanda: Run2-hcx40 Update the hit validation package to match Phase2 simulation
@cmsbuild cmsbuild merged commit 6135678 into cms-sw:CMSSW_7_6_X Oct 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants