Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary const cast away in LTCDigi #11745

Merged
merged 1 commit into from Oct 15, 2015
Merged

Remove unnecessary const cast away in LTCDigi #11745

merged 1 commit into from Oct 15, 2015

Conversation

Dr15Jones
Copy link
Contributor

The code was casting away const when it was not necessary. Changing
from C style casts to reinterpret_cast naturally avoids that.

@Dr15Jones
Remove unnecessary const cast away in LTCDigi
4f20892 
The code was casting away const when it was not necessary. Changing
from C style casts to reinterpret_cast naturally avoids that.
@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 13, 2015
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Remove unnecessary const cast away in LTCDigi

It involves the following packages:

DataFormats/LTCDigi

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8779/console

@cmsbuild
Copy link
Contributor

-1

Tested at: 4f20892
I found errors in the following unit tests:

---> test TestConfigDP had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11745/8779/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2757e40
a9c569b
cf422a9
d0367c2
56c6f12
16aa87b
062e6f9
3f62079
ed469b2
9ba6d58
861e695
81b5cb9
c4d6c6d
e29a7b0
00b6389
38915aa
ed25f88
b955f7a
0679e84
0b1bdaa
741f882
560a615
9cac5c7
2cf46fc
2c551cf
65c6e3e
aecb870
1a2a5b4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11745/8779/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11745/8779/git-merge-result

@smuzaffar
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8862/console

@cmsbuild
Copy link
Contributor

+1
Tested at: 4f20892
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11745/8862/summary.html

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11745/8862/summary.html

davidlange6 added a commit that referenced this pull request Oct 15, 2015
@davidlange6
Merge pull request #11745 from Dr15Jones/staticAnalysisFixLTCDigi
2759ae1 
Remove unnecessary const cast away in LTCDigi
@davidlange6 davidlange6 merged commit 2759ae1 into cms-sw:CMSSW_7_6_X Oct 15, 2015
@Dr15Jones Dr15Jones deleted the staticAnalysisFixLTCDigi branch October 19, 2015 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-available l1-pending orp-pending pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_7_6_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @smuzaffar @davidlange6