Removed unnecessary const_cast in DataFormats/L1GlobalTrigger

[Dr15Jones]

Removed const_cast which were then followed by reinterpret_cast
but whose value was bound to a const variable. Adding const to
the reinterpret_cast removed the need for const_cast.
This was found by the static analyzer.

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_6_X.

Removed unnecessary const_cast in DataFormats/L1GlobalTrigger

It involves the following packages:

DataFormats/L1GlobalTrigger

@cmsbuild, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[Dr15Jones]

Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8780/console

[cmsbuild]

-1

Tested at: c520df4
I found errors in the following unit tests:

---> test TestConfigDP had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11746/8780/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
2757e40
a9c569b
cf422a9
d0367c2
56c6f12
16aa87b
062e6f9
3f62079
ed469b2
9ba6d58
861e695
81b5cb9
c4d6c6d
e29a7b0
00b6389
38915aa
ed25f88
b955f7a
0679e84
0b1bdaa
741f882
560a615
9cac5c7
2cf46fc
2c551cf
65c6e3e
aecb870
1a2a5b4
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11746/8780/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11746/8780/git-merge-result

[smuzaffar]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8863/console

[cmsbuild]

+1
Tested at: c520df4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11746/8863/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11746/8863/summary.html