Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastSim : muon validation : use fastsim era to define fastsim customs #11790

Merged
merged 1 commit into from Oct 29, 2015
Merged

FastSim : muon validation : use fastsim era to define fastsim customs #11790

merged 1 commit into from Oct 29, 2015

Conversation

lveldere
Copy link
Contributor

This migration was discussed and agreed upon in this meeting:
See https://indico.cern.ch/event/442060/
(FastSim Validation Update)

E.g. migration for tracking validation has been done earlier #10922

For now this pr serves as a discussion forum.
I will contact muon validators for feedback, and help with tests.

@lveldere
Copy link
Contributor Author

please test

@cmsbuild cmsbuild added this to the Next CMSSW_7_6_X milestone Oct 14, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8838/console

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @lveldere for CMSSW_7_6_X.

FastSim : muon validation : use fastsim era to define fastsim customs

It involves the following packages:

FastSimulation/Validation
HLTriggerOffline/Common
HLTriggerOffline/Muon
SimMuon/MCTruth
Validation/RecoMuon

@civanch, @lveldere, @danduggan, @ssekmen, @mdhildreth, @cmsbuild, @deguio, @vanbesien can you please review it and eventually sign? Thanks.
@battibass, @abbiendi, @jhgoh, @Martin-Grunewald, @matt-komm, @trocino, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lveldere
Copy link
Contributor Author

closing until discussion with muon people is done

@lveldere lveldere closed this Oct 14, 2015
@cmsbuild
Copy link
Contributor

-1
Tested at: 0dfd2f4
you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11790/8838/summary.html

@lveldere lveldere reopened this Oct 21, 2015
@lveldere
Copy link
Contributor Author

please test

@lveldere lveldere closed this Oct 21, 2015
@lveldere lveldere reopened this Oct 21, 2015
@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/9087/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@lveldere
Copy link
Contributor Author

+1

comparisons ok,
muon validators have made a comparison with large statistics (1000 events), before vs after for fastsim ttbar, and found no discrepancies.

@civanch
Copy link
Contributor

civanch commented Oct 23, 2015

+1

@deguio
Copy link
Contributor

deguio commented Oct 28, 2015

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

davidlange6 added a commit that referenced this pull request Oct 29, 2015
FastSim : muon validation : use fastsim era to define fastsim customs
@davidlange6 davidlange6 merged commit 2510690 into cms-sw:CMSSW_7_6_X Oct 29, 2015
@lveldere lveldere deleted the fastsim-validation-muons branch November 9, 2015 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants