Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74x Fireworks: fix MuonDigi accessor type #11805

Merged
merged 1 commit into from Oct 24, 2015

Conversation

alja
Copy link
Contributor

@alja alja commented Oct 14, 2015

With ROOT6 muon digi accessor type was set to TVirtualCollectionProxyAccessor instead of fireworks specific FWItemMuonDigiAccessor.

Changing test order in FWItemAccessorFactory::accessorFor fixes the problem.

…r(). Give precendence fireworks plugin accessors before the case where memeber is TVirtualCollectionProxy.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alja (Alja Mrak-Tadel) for CMSSW_7_4_X.

75x Fireworks: fix MuonDigi accessor type

It involves the following packages:

Fireworks/Core

@cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@alja
Copy link
Contributor Author

alja commented Oct 14, 2015

Tim Cox reported that problem first. Where CSCStriDigi collection had size 35 instead of 1055.
tim1

@alja alja changed the title 75x Fireworks: fix MuonDigi accessor type 74x Fireworks: fix MuonDigi accessor type Oct 14, 2015
@alja
Copy link
Contributor Author

alja commented Oct 14, 2015

+1

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8883/console

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_7_6_X is complete. This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6 davidlange6 modified the milestones: Next CMSSW_7_4_X, Next CMSSW_7_6_X Oct 24, 2015
davidlange6 added a commit that referenced this pull request Oct 24, 2015
74x Fireworks: fix MuonDigi accessor type
@davidlange6 davidlange6 merged commit 764f442 into cms-sw:CMSSW_7_4_X Oct 24, 2015
@alja alja deleted the MuonDigi branch May 11, 2017 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants