Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the L1REPACK step work with the Run 2 eras #11817

Merged

Conversation

mark-grimes
Copy link

This PR is mainly to make the L1REPACK step work with the Run 2 eras. In doing so I've rearranged the era configuration slightly to make it a little more modular. Files import one new cff file, all of the commands in which are conditional on the stage1L1Trigger era being active. Hence it is always safe to import whether the Stage 1 trigger is being used or not. This simplifies the higher level config files, and should hopefully make them more intuitive.

If trigger experts have suggestions of a better arrangement please feel free to comment.

I've run diffs of the config files for the following workflows, and there are no differences:

1000.0,1001.0,1003.0,101.0,1306.0,1306.0,1330.0,135.1,135.4,140.53,25.0,25.0,250203.0,25202.0,25203.0,4.22,4.52,4.53,5.1,500203.0,50202.0,50203.0,8.0,9.0

@Martin-Grunewald - Once this is merged the AddOn tests will work with eras (I've checked) and I'll reopen #11690.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_6_X.

Make the L1REPACK step work with the Run 2 eras

It involves the following packages:

Configuration/StandardSequences
FastSimulation/Configuration
L1Trigger/Configuration

@ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @franzoni, @mulhearn, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @matt-komm, @cerati, @dgulhan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Martin-Grunewald
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8907/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@mulhearn
Copy link
Contributor

+1

davidlange6 added a commit that referenced this pull request Oct 16, 2015
Make the L1REPACK step work with the Run 2 eras
@davidlange6 davidlange6 merged commit 05c1670 into cms-sw:CMSSW_7_6_X Oct 16, 2015
@mark-grimes mark-grimes deleted the rearrangeStage1ConfigFiles branch October 16, 2015 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants