Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --dump_python option in cmsDriver #11823

Merged

Conversation

mark-grimes
Copy link

Currently, if you specify the --dump_python option to cmsDriver the resulting file will have none of the era changes applied. When execfile is used on the confg file during the if options.dump_python: branch, it picks up references to the modules already loaded (which don't have eras applied) rather than reloading any modules.
This fixes that by switching on any eras before the first reading of the modules.

@lveldere, @Dr15Jones

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_7_6_X.

Fix --dump_python option in cmsDriver

It involves the following packages:

Configuration/Applications

@cmsbuild, @franzoni, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @Martin-Grunewald this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

davidlange6 added a commit that referenced this pull request Oct 16, 2015
…eanly

Fix --dump_python option in cmsDriver
@davidlange6 davidlange6 merged commit 899b0db into cms-sw:CMSSW_7_6_X Oct 16, 2015
@mark-grimes mark-grimes deleted the fixPythonDumpInCmsDriverCleanly branch October 27, 2015 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants