Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCC ntupler 76x - October2015 #11832

Merged
merged 2 commits into from Oct 23, 2015

Conversation

capalmer85
Copy link
Contributor

update with BX splitting option;
includeJets (default off);
add .py for data certification with express stream

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @capalmer85 for CMSSW_7_6_X.

PCC ntupler 76x - October2015

It involves the following packages:

RecoLuminosity/LumiProducer

@cmsbuild, @cvuosalo, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
If you are a L2 or a release manager you can ask for tests by saying 'please test' in the first line of a comment.
@Degano you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@capalmer85
Copy link
Contributor Author

@davidlange6 @slava77 I'd like to get this merged relatively quickly because there are some significant updates that the lumi data certifiers need access to on a short time scale.

@slava77
Copy link
Contributor

slava77 commented Oct 15, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8934/console


if(includeJets){
hltjetsToken_=consumes<reco::CaloJetCollection >(edm::InputTag("ak4CaloJets"));
const int kMaxJetCal = 10000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

10k ak4 jets can't fit into CMS acceptance.
This looks excessive regarding memory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I stole this from elsewhere in cmssw, so I didn't look too carefully.)

const int kMaxJetCal = 10000;

What value would be acceptable?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even 100 is plenty enough.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@cmsbuild
Copy link
Contributor

Pull request #11832 was updated. @cmsbuild, @cvuosalo, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Oct 16, 2015

@cmsbuild please test

@cmsbuild
Copy link
Contributor

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/8936/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@capalmer85
Copy link
Contributor Author

@slava77 when should this be merged?

@slava77
Copy link
Contributor

slava77 commented Oct 21, 2015

+1

for #11832 fa1762c

  • PCC analysis ntupler update, not a part of centrally running workflows
  • jenkins tests pass (compiles)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_6_X IBs (tests are also fine). This pull request requires discussion in the ORP meeting before it's merged. @davidlange6, @Degano, @smuzaffar

@davidlange6
Copy link
Contributor

+1

cmsbuild added a commit that referenced this pull request Oct 23, 2015
@cmsbuild cmsbuild merged commit af34182 into cms-sw:CMSSW_7_6_X Oct 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants